Bug #46072

Scripts::executeCommand must support command arguments

Added by Dominique Feyer over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2013-03-06
Due date:
% Done:

100%

PHP Version:
Has patch:
No
Complexity:

Description

Currently it's not supported to have command arguments in a CLI subcommand, this patch propose to solve this with this API, and it's not a breaking change:

Scripts::executeCommand('namespace.vendor:command:action', $this->settings, TRUE, array('--arg1', $value1, '--arg2', $value2));

Everything is correctly escaped, patch is coming

Associated revisions

Revision aa3f832d (diff)
Added by Dominique Feyer over 6 years ago

[FEATURE] Support arguments in Scripts::executeCommand

Previously it was not supported to have command arguments in a CLI
subcommand. This patch solves this issue by adding a $commandArguments
parameter to the executeCommand() method.

Resolves: #46072
Releases: 2.0, master
Change-Id: Ie045e6aaefea7803516745a4dd0d9ab9453106f1

Revision 5ee0e9de (diff)
Added by Dominique Feyer over 6 years ago

[FEATURE] Support arguments in Scripts::executeCommand

Previously it was not supported to have command arguments in a CLI
subcommand. This patch solves this issue by adding a $commandArguments
parameter to the executeCommand() method.

Resolves: #46072
Releases: 2.0, master
Change-Id: Ie045e6aaefea7803516745a4dd0d9ab9453106f1

History

#1 Updated by Dominique Feyer over 6 years ago

Better API (respect the storage format of the current command in this->request->getArguments()

Scripts::executeCommand('namespace.vendor:command:action', $this->settings, TRUE, array('arg1' => $value1, 'arg2' => $value2));

#2 Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18758

#3 Updated by Dominique Feyer over 6 years ago

Better API (respect the storage format of the current command in this->request->getArguments()

Scripts::executeCommand('namespace.vendor:command:action', $this->settings, TRUE, array('arg1' => $value1, 'arg2' => $value2));

#4 Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18758

#5 Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18758

#6 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19830

#7 Updated by Dominique Feyer over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF