Bug #46337

Remove (costly) file_exists calls in class loading

Added by Christian Müller over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Should have
Category:
-
Target version:
-
Start date:
2013-03-15
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
No
Complexity:
#1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18873

#2

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18873

#3

Updated by Christian Müller over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#4

Updated by Norbert Sendetzky over 8 years ago

My tests have shown that using file_exists() is faster than using @include when the file doesn't exist. As this is the most common case when several include paths are available, it's likely that this patch will slow down class loading instead of improving it.

#5

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19062

#6

Updated by Christian Müller over 8 years ago

  • Status changed from Under Review to Resolved
#7

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch composer has been pushed to the review server.
It is available at https://review.typo3.org/19359

#8

Updated by Christian Müller over 8 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF