Task #46352

Roles in SecurityContext should be kept until tokens change

Added by Christian Müller over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Should have
Assignee:
Christian Müller
Category:
Security
Target version:
-
Start date:
2013-03-16
Due date:
% Done:

100%

Estimated time:
Sprint:
PHP Version:
Has patch:
No
Complexity:

Description

GetRoles inside SecurityContext rebuilds the array of roles on every call which is costly and leads to a lots of created objects if roles (for example in fluid) are used a lot.

As for the building only two things are responsible, a) all available roles and b) tokens we can for now safely keep the roles until tokens change.

As soon as roles are objects that could be modified during runtime you might need to clear the array if you change the existing roles.

#1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18968

#2

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18968

#3

Updated by Christian Müller over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#4

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19110

#5

Updated by Marco Falkenberg over 8 years ago

After applying the patch authentication via HTTP-Basic (PersistedUsernamePasswordProvider & UsernamePasswordHttpBasic-Token) throws

#1222268609: Access denied (0 denied, 0 granted, 1 abstained)

#6

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch composer has been pushed to the review server.
It is available at https://review.typo3.org/19368

#7

Updated by Christian Müller over 8 years ago

  • Status changed from Under Review to Resolved
#8

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19110

#9

Updated by Christian Müller over 8 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF