Task #46352
Roles in SecurityContext should be kept until tokens change
100%
Description
GetRoles inside SecurityContext rebuilds the array of roles on every call which is costly and leads to a lots of created objects if roles (for example in fluid) are used a lot.
As for the building only two things are responsible, a) all available roles and b) tokens we can for now safely keep the roles until tokens change.
As soon as roles are objects that could be modified during runtime you might need to clear the array if you change the existing roles.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18968
Updated by Gerrit Code Review almost 8 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18968
Updated by Christian Müller almost 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 5241493c41d0829cb67066e1bfc0cf9d7b1ef8bc.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19110
Updated by Marco Falkenberg almost 8 years ago
After applying the patch authentication via HTTP-Basic (PersistedUsernamePasswordProvider & UsernamePasswordHttpBasic-Token) throws
#1222268609: Access denied (0 denied, 0 granted, 1 abstained)
Updated by Gerrit Code Review almost 8 years ago
Patch set 1 for branch composer has been pushed to the review server.
It is available at https://review.typo3.org/19368
Updated by Christian Müller almost 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset 9f6ff0818cc8ace51fee4c3ab5ae2eeecd6fd59e.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19110
Updated by Christian Müller almost 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset 750ad089bc8f8b26f362bb2e340fb3738b373076.