Bug #46485

The exceptionhandler handles exceptions too strict

Added by Rens Admiraal over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2013-03-21
Due date:
% Done:

100%

Estimated time:

Description

The ExceptionHandler should check if error_reporting is enabled. This is because we set the execptionhandler in testing context (for example).
In http://ca2.php.net/manual/en/language.operators.errorcontrol.php it's stated that even though the @ is used the exceptionhandler will be called if set_error_handler is used.

For this reason we should check in the exception handler if errors are ignored by using error_reporting() === 0

#1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19125

#2

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19126

#3

Updated by Rens Admiraal over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:706fee4a2f7fa0a1c98b1177c28810b247919a45.

#4

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch composer has been pushed to the review server.
It is available at https://review.typo3.org/19374

#5

Updated by Rens Admiraal over 8 years ago

  • Status changed from Under Review to Resolved

Applied in changeset commit:07b753c68e66a4ca4631e1c42b73e1299d86208b.

Also available in: Atom PDF