Task #47859

Logging: Do not log all decisions in \TYPO3\Flow\Security\Aspect\LoggingAspect

Added by Christopher Hlubek over 8 years ago. Updated about 8 years ago.

Status:
Accepted
Priority:
Should have
Assignee:
Category:
Security
Target version:
-
Start date:
2013-05-03
Due date:
% Done:

0%

Estimated time:
Sprint:
PHP Version:
Has patch:
No
Complexity:

Description

Logging all decisions for decideOnJoinPoint() and decideOnResource() is way to much if these decisions are used conditionally (e.g. for the UI). This could end up with a lot of log entries (and of course some overhead).

#1

Updated by Robert Lemke over 8 years ago

  • Status changed from New to Needs Feedback
  • Target version set to 2.1

Can you point me to where this is logged? Couldn't find it right away. If it's LOG_DEBUG, I don't consider this a problem though.

#2

Updated by Robert Lemke over 8 years ago

  • Category set to Security
#3

Updated by Robert Lemke over 8 years ago

  • Target version deleted (2.1)
#4

Updated by Christopher Hlubek over 8 years ago

Robert Lemke wrote:

Can you point me to where this is logged? Couldn't find it right away. If it's LOG_DEBUG, I don't consider this a problem though.

See \TYPO3\Flow\Security\Aspect\LoggingAspect::logJoinPointAccessDecisions for example. It's all LOG_INFO, which is to high IMHO (imagine iterating over objects and logging every decision).

#5

Updated by Karsten Dambekalns about 8 years ago

  • Status changed from Needs Feedback to Accepted
  • Assignee set to Robert Lemke

Also available in: Atom PDF