Bug #51239

AbstractViewHelper use incorrect method signature for "$this->systemLogger->log()"

Added by Timo Dödtmann over 7 years ago. Updated over 6 years ago.

Status:
Under Review
Priority:
Must have
Assignee:
Category:
Core
Target version:
-
Start date:
2013-08-21
Due date:
% Done:

0%

Estimated time:
Has patch:
Yes

Description

Within the `AbstractViewHelper::callRenderMethod()` a log entry will be created if en exception is thrown.
But the method signature of the systemLogger (\TYPO3\Flow\Log\LoggerInterface) looks slightly different to the method call.

TYPO3\Flow\Log\LoggerInterface

public function log($message, $severity = LOG_INFO, $additionalData = NULL, $packageKey = NULL, $className = NULL, $methodName = NULL);

vs.

TYPO3\Fluid\Core\ViewHelper\AbstractViewHelper

$this->systemLogger->log('An Exception was captured: '. $exception->getMessage() . '(' . $exception->getCode() . ')', LOG_ERR, 'TYPO3.Fluid', get_class($this));

The `$additionalData` is missing.


Files

patch.patch (813 Bytes) patch.patch Timo Dödtmann, 2013-08-21 17:20
#1

Updated by Adrian Föder almost 7 years ago

  • Status changed from New to Accepted
  • Assignee set to Adrian Föder
  • Priority changed from Should have to Must have
#2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.Fluid has been pushed to the review server.
It is available at https://review.typo3.org/29377

#3

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.Fluid has been pushed to the review server.
It is available at https://review.typo3.org/29377

#4

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.Fluid has been pushed to the review server.
It is available at https://review.typo3.org/29377

Also available in: Atom PDF