Bug #51411: Label user function for sys_file_reference uses HTML - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #51411

closed

Label user function for sys_file_reference uses HTML

Added by Oliver Hader over 10 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Philipp Gampe

Category:

File Abstraction Layer (FAL)

Target version:

Start date:

2013-08-27

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

5.3

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

The label user function for sys_file_reference uses HTML which results in strange data in the workspace module, the admin log and possibly also in other components that list sys_file_reference records in a list (see attached screenshots).

This behaviour has been introduced with this change:
https://review.typo3.org/21916

Files

Download all files

Bildschirmfoto_2013-08-27_um_22.27.41.png (20.8 KB) Bildschirmfoto_2013-08-27_um_22.27.41.png	Admin Log Module	Oliver Hader, 2013-08-27 22:31
Bildschirmfoto_2013-08-27_um_22.28.23.png (46.8 KB) Bildschirmfoto_2013-08-27_um_22.28.23.png	Workspace Module	Oliver Hader, 2013-08-27 22:31

Actions

Copy link

Updated by Markus Klein over 10 years ago

What do you propose to change here?

What do you want to see as label in the Workspace Module?

I'd say we change the InlineElement.php to add another option/parameter/whatever to the userfunc called, such that the userfunc can distinguish between normal labeling and inline labeling.

Actions

Copy link

Updated by Philipp Gampe over 10 years ago

IMHO a bug of the inline label part ... there should be two seperate functions for labels. One for TCEfroms and one for inline labels in the backend.

Actions

Copy link

Updated by Philipp Gampe over 10 years ago

Status changed from New to Needs Feedback

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Status changed from Needs Feedback to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23528

Actions

Copy link

Updated by Philipp Gampe over 10 years ago

Assignee set to Philipp Gampe

I changed this to a new config option inlineLabel_userFunc with the same signature as the label_userFunc.

The function InlineElement::renderForeignRecordHeader is only called from InlineElement::renderForeignRecord which in turn is only used to render IRRE fields AFAICT.

That way all other places preserve the behavior.

Actions

Copy link