Feature #52072

Make Port in Varnish Tasks configurable

Added by Michael Knoll about 6 years ago. Updated almost 4 years ago.

Status:
Accepted
Priority:
Won't have this time
Assignee:
-
Target version:
-
Start date:
2013-09-17
Due date:
% Done:

0%


Description

The Varnish ban and purge tasks have the port for Varnish management hardcoded. Since there might be different ports than 6082 for that, this should be configurable see patch below.

        $secretFile = (isset($options['secretFile']) ? $options['secretFile'] : '');
        $purgeUrl = (isset($options['purgeUrl']) ? $options['purgeUrl'] : '"ban.url ."');
        $varnishadm = (isset($options['varnishadm']) ? $options['varnishadm'] : '/usr/bin/varnishadm');
        $varnishport = (isset($options['varnishport']) ? $options['varnishport'] : '6082');
        $varnishport = '-T 127.0.0.1:' . $varnishport;
        $varnishsecret = ($secretFile !== '' ? '-S ' . $secretFile . ' ' : ' ');
        $this->shell->executeOrSimulate($varnishadm . $varnishsecret . $varnishport . ' ' . $purgeUrl, $node, $deployment);

Btw: is there any possibility to do a pull request for the surf project, that would make fixes easier...

History

#1 Updated by Helmut Hummel almost 4 years ago

  • Tracker changed from Bug to Feature
  • Status changed from New to Accepted
  • Priority changed from Should have to Won't have this time

Development of TYPO3 Surf now moved to Github. If you think this is still relevant, please open a bug report or feature request here:

https://github.com/TYPO3/Surf

Btw: is there any possibility to do a pull request for the surf project, that would make fixes easier...

Yes, now there is :)

Looking forward to see your pull request there

Also available in: Atom PDF