http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692013-10-22T01:04:33ZTYPO3 ForgeTYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1877182013-10-22T01:04:33ZStefan Aebischertypo3@pixtron.ch
<ul></ul><p>The namespaced eval function generates an invalid javascript function name "function SpoonerWeb\BeSecurePw\Evaluation\PasswordEvaluator(newValue)". In chrome this breaks all the TBE_EDITOR definitions and with that all the functionality in jsfunc.tbe_editor.js.</p>
<p>This diff was a quick try to solve the bug. Unfortunately it is not well tested and i have no idea what regressions it could introduce. Therefore it is not ready for a gerrit PR. I posted it anyway because it could lead the guys with a deeper understanding of the TYPO3 BE form internals, where to get their hands dirty.<br /><a class="external" href="https://gist.github.com/pAlpha627/7092156">https://gist.github.com/pAlpha627/7092156</a></p>
<p>Indeed it would be nice, to have a possibility to use namespaced "eval" functions. At least there should be some syntax checks for the generated Javascript in TYPO3\CMS\Backend\Form\FormEngine, in oder to avoid breaking the whole functionality.</p>
<p>BTW: As of now the master branch of be_secure_pw contained only "PasswordEvaluator" and not "SpoonerWeb\\BeSecurePw\\Evaluation\\PasswordEvaluator" as mentioned in the Bug report. In order to reproduce the bug you have to change the $TCA['be_users']['columns']['password']['config']['eval'] in be_secure_pw/ext_tables.php.</p> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1877342013-10-22T09:21:13ZThomas Löffler
<ul></ul><p>Thanks for the patch. I will have a look on it.<br />Yes, I thought I pushed the last commit, but I've seen that I forgot to do it. :)</p> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1883372013-10-28T22:59:18ZThomas Löffler
<ul></ul><p>Hi Stefan,</p>
<p>this patch works for me and is not breaking any functionality of other evaluators.<br />I would suggest to push it to Gerrit. The reviewing people will have corrections for the code, if there are any. :)</p>
<p>Will you push it or should I?</p>
<p>Thomas</p> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1883402013-10-28T23:23:10ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/25041">https://review.typo3.org/25041</a></p> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1883432013-10-28T23:35:29ZStefan Aebischertypo3@pixtron.ch
<ul></ul><blockquote>
<p>Will you push it or should I?</p>
</blockquote>
<p>Hi Thomas fine for me if you push it</p>
<p>Stefan</p> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1884212013-10-29T18:44:28ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/25041">https://review.typo3.org/25041</a></p> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1884222013-10-29T18:47:16ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/25041">https://review.typo3.org/25041</a></p> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1885772013-10-31T05:42:54ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/25041">https://review.typo3.org/25041</a></p> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1891712013-11-07T21:38:52ZGerrit Code Review
<ul></ul><p>Patch set 5 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/25041">https://review.typo3.org/25041</a></p> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1895552013-11-11T19:59:42ZGerrit Code Review
<ul></ul><p>Patch set 6 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/25041">https://review.typo3.org/25041</a></p> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1895572013-11-11T20:01:02ZThomas Löffler
<ul></ul>Reproduction:
<ul>
<li>Download extension "be_secure_pw" (master branch) from <a class="external" href="https://github.com/spoonerWeb/be_secure_pw">https://github.com/spoonerWeb/be_secure_pw</a></li>
<li>Install it</li>
<li>Try to edit a be_user record</li>
</ul> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1897532013-11-12T16:15:09ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_6-1</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/25317">https://review.typo3.org/25317</a></p> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1897542013-11-12T16:16:18ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_6-0</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/25318">https://review.typo3.org/25318</a></p> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=1897592013-11-12T16:30:28ZAnonymous
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[BUGFIX] Evaluator in JS fails with namespaces If you add an own evaluator, you have to insert t..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/f1137735693dd70d073b323d3af7e85499ebda2b">f1137735693dd70d073b323d3af7e85499ebda2b</a>.</p> TYPO3 Core - Bug #52904: Namespace problem in JS when extending TCA evalfieldshttp://forge.typo3.org/issues/52904?journal_id=3471732017-10-23T21:45:48ZRiccardo De Contardierredeco@gmail.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>