Bug #52923

The CaseImplementation does not support TypoScript debug mode correctly

Added by Dominique Feyer almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Should have
Category:
-
Target version:
-
Start date:
2013-10-17
Due date:
% Done:

100%


Description

$renderedMatcher !== self::MATCH_NORESULT is always FALSE when using TypoScript debug mode something like if (strpos($renderedMatcher, self::MATCH_NORESULT) === FALSE) should work

Associated revisions

Revision 405dd1c3 (diff)
Added by Christopher Hlubek almost 6 years ago

[BUGFIX] Support debug mode for CaseImplementation

The Case object did not match result correctly in debug mode, since the
rendered output of a matcher is annotated with debug comments and does
not equal the MATCH_NORESULT constant.

This change strips these comments from the rendered output if the debug
mode is enabled before comparing the strings.

To test the behavior a setter for the debug mode was introduced to the
TypoScript Runtime and an option was added to the TypoScriptView.

Change-Id: Ic0d24ddfb35a62a49f4e1d959a4dbe892c260d14
Fixes: #52923
Reviewed-on: https://review.typo3.org/24955
Tested-by: Mr. Hudson
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Christopher Hlubek
Tested-by: Christopher Hlubek
Reviewed-by: Sebastian Kurfuerst
Tested-by: Sebastian Kurfuerst

History

#1 Updated by Dominique Feyer almost 6 years ago

  • Project changed from TYPO3.Neos to TYPO3.TypoScript

#2 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24955

#3 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24955

#4 Updated by Christopher Hlubek almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF