Project

General

Profile

Actions
Copy link

Bug #53200

closed

Double htmlspecialchars in UserFileInlineLabelService

Added by Alexander Stehlik over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2013-10-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

Currently it can happen that htmlspecialchars() is applied twice to a file title. This becomes a real problem when the title of the filename is too long and it gets cropped by BackendUtility::getRecordTitlePrep().

Please find a screenshot attached to see the result.

Solution: only use htmlspecialchars() if value does not come from BackendUtility::getRecordTitlePrep() or BackendUtility::getRecordTitle().

Files

screenshot_htmlspecialchars_file.png (43.2 KB) screenshot_htmlspecialchars_file.png Alexander Stehlik, 2013-10-29 16:46
Actions
Copy link
 #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/25052

Actions
Copy link
 #2

Updated by Alexander Stehlik over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF