http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692013-11-16T17:32:47ZTYPO3 ForgeTYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1903442013-11-16T17:32:47ZMarkus Kleinmarkus.klein@typo3.org
<ul><li><strong>Category</strong> set to <i>Backend API</i></li><li><strong>Target version</strong> set to <i>next-patchlevel</i></li><li><strong>PHP Version</strong> set to <i>5.5</i></li></ul><p>Where does it occur exactly? This can happen in Core at two places?</p>
The exception codes are:
<ul>
<li>1195126772, BackendController:152</li>
<li>1195125501, BackendController:679</li>
</ul> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1903572013-11-16T19:21:00ZJeff Segarsjsegars@alumni.rice.edu
<ul></ul><p>I noticed the same error yesterday, thrown inside \TYPO3\CMS\Backend\Controller\BackendController->initializeCoreToolbarItems(). I've seen it on 4.7, 6.0, and 6.2 (haven't tested 4.5 or 6.1 yet). When I downgrade to PHP 5.5.5 the issue goes away.</p>
<p>From my initial investigation, the problem is in some way connected to using reflection and constructor arguments when creating the instance of the toolbar item. Inside initializeCoreToolbarItems, we have a call to makeInstance(), passing along $this as a constructor argument. Inside makeInstance(), reflection is used when handling arguments. At line 4179 of \TYPO3\CMS\Core\Utility\GeneralUtility we have "$instance = $reflectedClass->newInstanceArgs($constructorArguments)" which returns null. If I switch it to newInstance() instead, I get a valid object back.</p>
<p>That's about as far as I've made it in debugging for now, but maybe some of that info is helpful.</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1904002013-11-17T19:42:57ZAlexander Bigga
<ul></ul><p>Same problem here on current Arch Linux:</p>
<ul>
<li>PHP 5.5.6</li>
<li>TYPO3 6.1.5 (introduction package)</li>
</ul>
<pre>
#1195126772: $toolbarItem "shortcuts" must implement interface TYPO3\CMS\Backend\Toolbar\ToolbarItemHookInterface (More information)
UnexpectedValueException thrown in file
/[...]/typo3_src-6.1.5/typo3/sysext/backend/Classes/Controller/BackendController.php in line 148.
</pre>
<p>I was looking for an explanation and never had PHP in mind :-(</p>
<p>Alexander</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1907212013-11-19T14:27:35ZMarkus Kleinmarkus.klein@typo3.org
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Accepted</i></li><li><strong>TYPO3 Version</strong> changed from <i>6.2</i> to <i>4.5</i></li></ul><p>Joerg Neikes wrote:</p>
<blockquote>
<p>graphicsmagic does not work too.</p>
<p>With php 5.5.5 all works fine.</p>
<p>May be a wrong bug fix in php update.</p>
<p>The running system is a gentoo ~x64 distributon with updates from 18.11.2013.</p>
</blockquote> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1908712013-11-20T02:03:40ZMarkus Kleinmarkus.klein@typo3.org
<ul></ul><p><strong>Related bug report:</strong> <a class="external" href="https://bugs.php.net/bug.php?id=66107">https://bugs.php.net/bug.php?id=66107</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1918022013-11-26T22:55:48ZErnesto Baschnyeb@cron.eu
<ul></ul><p>See also discussion in this "Tweet" (!!):</p>
<p><a class="external" href="https://twitter.com/SwiftLizard/status/405419858864533504">https://twitter.com/SwiftLizard/status/405419858864533504</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1918052013-11-26T23:30:49ZMarkus Kleinmarkus.klein@typo3.org
<ul></ul><p>The reference in the constructor was introduced with <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: add the workspace selector to the cleaner backend toolbar (Closed)" href="http://forge.typo3.org/issues/17795">#17795</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1918072013-11-27T00:09:05ZChris Zepernickchris.zepernick@noerdisch.de
<ul><li><strong>File</strong> <a href="/attachments/25605">test.php</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25605/test.php">test.php</a> added</li></ul><p>The Problem does not only occur in TYPO3 Version 4.x but also 6.x.<br />The Bug is not caused by TYPO3 but by PHP ReflectionClass::newInstanceArgs($array); <br />If a parameter is passed by reference the Bug occurs.</p>
<p>The Bug can be avoided in this case by altering :</p>
<ul>
<li>typo3_src/typo3/sysext/backend/Classes/Toolbar/ToolbarItemHookInterface </li>
<li>typo3_src/typo3/sysext/backend/Classes/Toolbar/ShortcutToolbarItem </li>
<li>typo3_src/typo3/sysext/backend/Classes/Toolbar/LiveSearchToolbarItem </li>
<li>typo3_src/typo3/sysext/backend/Classes/Toolbar/ClearCacheToolbarItem</li>
</ul>
<p>alter: "public function __construct(\TYPO3\CMS\Backend\Controller\BackendController <strong>&</strong>$backendReference = NULL)“ <br />to: "public function __construct(\TYPO3\CMS\Backend\Controller\BackendController $backendReference = NULL)“</p>
<p>These "pass by reference" are unnecessary since PHP5 because Objects are always passed by reference.</p>
<p>After that change TYPO3 should mostly work as expected.</p>
<p>Little Testcase attached.<br />Tested with this VagrantBox: <a class="external" href="https://github.com/swiftlizard/VagrantTYPO3Flow">https://github.com/swiftlizard/VagrantTYPO3Flow</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1921092013-11-29T17:35:40ZArtus Kolanowskiartus@ionoi.net
<ul></ul><p>Chris Zepernick wrote:</p>
<blockquote>
<p>The Problem does not only occur in TYPO3 Version 4.x but also 6.x...</p>
</blockquote>
<p>Thanks! Helped me to fix a running TYPO3 6.1.5. The Hoster just switched to PHP 5.5.6 without telling anybody...</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1921192013-11-29T19:43:44ZStefan Neufeindtypo3.neufeind@speedpartner.de
<ul></ul><p>It seems PHP is <strong>not</strong> going to fix this in 5.5.7, though I would have expected that because it's a regression. Preliminary changelog for 5.5.7RC1:<br /><a class="external" href="https://github.com/php/php-src/blob/php-5.5.7RC1/NEWS">https://github.com/php/php-src/blob/php-5.5.7RC1/NEWS</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1921592013-11-30T11:40:13ZViktor Livakivskyiinvisible.kinder@gmail.com
<ul></ul><p>Chris Zepernick wrote:</p>
<blockquote>
<p>The Bug can be avoided in this case by altering :</p>
<ul>
<li>typo3_src/typo3/sysext/backend/Classes/Toolbar/ToolbarItemHookInterface </li>
<li>typo3_src/typo3/sysext/backend/Classes/Toolbar/ShortcutToolbarItem </li>
<li>typo3_src/typo3/sysext/backend/Classes/Toolbar/LiveSearchToolbarItem </li>
<li>typo3_src/typo3/sysext/backend/Classes/Toolbar/ClearCacheToolbarItem</li>
</ul>
<p>alter: "public function __construct(\TYPO3\CMS\Backend\Controller\BackendController <strong>&</strong>$backendReference = NULL)“ <br />to: "public function __construct(\TYPO3\CMS\Backend\Controller\BackendController $backendReference = NULL)“</p>
</blockquote>
In my TYPO3 6.0.10 instance I've had also to fix same in these files:
<ul>
<li>typo3_src/typo3/sysext/workspaces/Classes/ExtDirect/WorkspaceSelectorToolbarItem.php</li>
<li>typo3_src/typo3/sysext/opendocs/Classes/Controller/OpendocsController.php</li>
<li>typo3_src/typo3/sysext/sys_action/Classes/ActionToolbarMenu.php</li>
</ul>
<p>Because they are using same interface.</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1923122013-12-01T00:05:00ZArtus Kolanowskiartus@ionoi.net
<ul></ul><p>Here is the next one:</p>
<ul>
<li>typo3_src/typo3/sysext/backend/Classes/Form/Element/TreeElement.php</li>
</ul>
<p>Otherwise I'm not able to edit BE users (<code>Fatal error: Call to a member function renderField() on a non-object in [...]/typo3_src-6.1.6/typo3/sysext/backend/Classes/Form/FormEngine.php on line 1749</code>).</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1928612013-12-06T14:25:21ZDavid Bruchmanndavid.bruchmann@gmail.com
<ul></ul><p>Just searching for "&$" in the core including the sysext-folder I found 1346 occurrences in version 6.1.<br />Some are in comments, some are for arrays, nevertheless the changed behavior of php seems being some work for TYPO3.</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1928622013-12-06T14:41:12ZFrenck Lutke
<ul></ul><p>David Bruchmann wrote:</p>
<blockquote>
<p>Just searching for "&$" in the core including the sysext-folder I found 1346 occurrences in version 6.1.<br />Some are in comments, some are for arrays, nevertheless the changed behavior of php seems being some work for TYPO3.</p>
</blockquote>
<p>The only changes needed due to this PHP bug are with references in constructors, of which there are only ~10 occurrences in core (depends on version), of which most were already mentioned in these comments. These are all objects, so there is no functional difference when changing their reference declaration.</p>
<p>You can easily confirm, as well as find any offending extensions in your installation, with a simple regular expression: (?<=__construct\()(.*&.+)(?=\))</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1929082013-12-07T13:01:45ZPhilipp Gampephilipp.gampe@typo3.org
<ul><li><strong>File</strong> <a href="/attachments/25663">php-5.5.6.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25663/php-5.5.6.patch">php-5.5.6.patch</a> added</li></ul><p>Attached is a patch against current master that should work across 6.x. Please not that it breaks any extension that uses the interface to add toolbar items.</p>
<p>IMHO we should wait for a patch from the PHP.</p>
<p>Hint: use $ git apply php-5.5.6.patch to read in the patch file</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1930032013-12-08T03:10:58ZPhilipp Gampephilipp.gampe@typo3.org
<ul></ul><p>Same issue in typo3/sysext/backend/Classes/Form/Element/TreeElement.php</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1930102013-12-08T11:10:29ZMarkus Kleinmarkus.klein@typo3.org
<ul><li><strong>Subject</strong> changed from <i>Backend does not work with PHP 5.5.6</i> to <i>Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'</i></li></ul> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1961542013-12-10T20:48:21ZMarkus Kleinmarkus.klein@typo3.org
<ul></ul><p>Some news from the PHP bug tracker:</p>
<blockquote>
<p>I've reverted changes in PHP-5.5 (not in PHP-5.6 and above).</p>
</blockquote> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1961612013-12-11T02:24:25ZStefan Neufeindtypo3.neufeind@speedpartner.de
<ul></ul><p>Thanks. So for now we can expect a fixed 5.5.7 some time. But we'll still need the change for 5.6+ then. Planned release for 5.6 is sometime around August 2014.</p>
<p><a class="external" href="http://comments.gmane.org/gmane.comp.php.devel/82450">http://comments.gmane.org/gmane.comp.php.devel/82450</a></p>
<blockquote>
<p>It's already mid-october and according to our release schedule we have to</p>
</blockquote>
<p>release PHP 5.6 in 10 months from now.</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1961742013-12-11T10:40:49ZMarkus Kleinmarkus.klein@typo3.org
<ul></ul><p>Yes we indeed need a fix for TYPO3 as well. It does not make sense to pass the parameters as reference (nowadays) since we don't modify the variable in our constructors.</p>
<p>IMHO it is best to go with this breaking change now, before the 6.2 release.</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1962392013-12-12T00:01:05ZPhilipp Gampephilipp.gampe@typo3.org
<ul></ul><p>Related work-around: <a class="external" href="https://review.typo3.org/#/c/26344/3">https://review.typo3.org/#/c/26344/3</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1962472013-12-12T00:51:43ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Under Review</i></li></ul><p>Patch set 4 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26344">https://review.typo3.org/26344</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1962792013-12-12T08:53:48ZHelmut Hummeltypo3@helhum.io
<ul></ul><p>Markus Klein wrote:</p>
<blockquote>
<p>IMHO it is best to go with this breaking change now, before the 6.2 release.</p>
</blockquote>
<p>Why not completely remove the constructor from the interface? That is bad style anyway.</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1963332013-12-12T15:08:19ZStefan Neufeindtypo3.neufeind@speedpartner.de
<ul></ul><p>Timetable for PHP 5.6: <a class="external" href="https://wiki.php.net/todo/php56#timetable">https://wiki.php.net/todo/php56#timetable</a><br />alpha1 in January (so we could start testing), final in June</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1963362013-12-12T15:25:50Zpatr no-lastname-givenscp@befast.ch
<ul></ul><p>I have typo3 4.7.17 same problem.</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1963972013-12-12T22:44:51ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26363">https://review.typo3.org/26363</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1963982013-12-12T23:03:43ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26363">https://review.typo3.org/26363</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1964432013-12-13T12:12:44ZStefan Neufeindtypo3.neufeind@speedpartner.de
<ul></ul><p>PHP 5.5.7 has just been released. But if I see a fix for our problem in the changelog :-(<br /><a class="external" href="http://www.php.net/ChangeLog-5.php#5.5.7">http://www.php.net/ChangeLog-5.php#5.5.7</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1965072013-12-13T22:46:02ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26363">https://review.typo3.org/26363</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1965092013-12-14T00:45:21ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26363">https://review.typo3.org/26363</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1965102013-12-14T00:57:02ZGerrit Code Review
<ul></ul><p>Patch set 5 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26363">https://review.typo3.org/26363</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1965512013-12-14T18:05:48ZPhilipp Gampephilipp.gampe@typo3.org
<ul></ul><p>another place for 4.5:<br />/typo3/sysext/em/classes/repository/class.tx_em_repository_utility.php</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1965932013-12-14T22:24:36ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_6-1</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26413">https://review.typo3.org/26413</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1965942013-12-14T22:24:53ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_6-0</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26414">https://review.typo3.org/26414</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1965972013-12-14T22:30:24ZHelmut Hummeltypo3@helhum.io
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[TASK] Optimize speed for instantiating class with arguments PHP reflection has quite an overhea..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/6eb7a548125a945316f8ad32eb3e5481a28ae2d6">6eb7a548125a945316f8ad32eb3e5481a28ae2d6</a>.</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1966002013-12-14T23:35:40ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>TYPO3_4-7</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26416">https://review.typo3.org/26416</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1979182014-01-04T16:46:55ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>TYPO3_6-1</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26413">https://review.typo3.org/26413</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1979192014-01-04T16:50:30ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>TYPO3_6-0</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26414">https://review.typo3.org/26414</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1979202014-01-04T17:03:40ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>TYPO3_4-7</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26416">https://review.typo3.org/26416</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1979212014-01-04T17:09:37ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>TYPO3_4-7</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26416">https://review.typo3.org/26416</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1979222014-01-04T17:12:36ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>TYPO3_4-7</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26416">https://review.typo3.org/26416</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1979232014-01-04T17:14:42ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_4-5</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/26643">https://review.typo3.org/26643</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1979262014-01-04T17:30:26ZHelmut Hummeltypo3@helhum.io
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="[TASK] Optimize speed for instantiating class with arguments PHP reflection has quite an overhea..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/dd187dd1b3bb2e38ed7dd989efd1055f053cd880">dd187dd1b3bb2e38ed7dd989efd1055f053cd880</a>.</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1979282014-01-04T17:36:18ZMarkus Kleinmarkus.klein@typo3.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Under Review</i></li></ul><p>Still the 4.7 and 4.5 patches are pending</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=1996492014-01-17T09:30:38ZHelmut Hummeltypo3@helhum.io
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="[TASK] Optimize speed for instantiating class with arguments PHP reflection has quite an overhea..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/2526bddb5b27ca832575fad809facfa39c7db225">2526bddb5b27ca832575fad809facfa39c7db225</a>.</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=2327612014-10-14T14:04:22ZClaas Hilbrechtclaas.hilbrecht@linum.com
<ul></ul><p>Helmut Hummel wrote:</p>
<blockquote>
<p>Applied in changeset <a class="changeset" title="[TASK] Optimize speed for instantiating class with arguments PHP reflection has quite an overhea..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/2526bddb5b27ca832575fad809facfa39c7db225">2526bddb5b27ca832575fad809facfa39c7db225</a>.</p>
</blockquote>
<p>The changeset was removed with ab6256f from 4.5LTS and is not included anymore (and it seems no other patch that fixes the originating problem). I cherry-picked the patch and it seems to work but I wonder why it was removed without any other fix?</p>
<p>2014-01-17 ab6256f Revert "[TASK] Optimize speed for instantiating class with arguments" (Ernesto Baschny)<br />2014-01-17 2526bdd <a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface' (Closed)" href="http://forge.typo3.org/issues/53682">#53682</a> [TASK] Optimize speed for instantiating class with arguments (Helmut Hummel)</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=2327632014-10-14T14:13:50ZHelmut Hummeltypo3@helhum.io
<ul></ul><p>Claas Hilbrecht wrote:</p>
<blockquote>
<p>2014-01-17 ab6256f Revert "[TASK] Optimize speed for instantiating class with arguments" (Ernesto Baschny)</p>
</blockquote>
<p>It was reverted (only) because of a compatibility issue with PHP 5.2 (see: <a class="external" href="https://review.typo3.org/#/c/26910/">https://review.typo3.org/#/c/26910/</a>)</p>
<p>I would be in favor of getting this in again with self:: instead of static:: for 4.5</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=2327642014-10-14T14:18:30ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/33307">http://review.typo3.org/33307</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=2327652014-10-14T14:22:01ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_4-5</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/33308">http://review.typo3.org/33308</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=2327742014-10-14T14:58:48ZClaas Hilbrechtclaas.hilbrecht@linum.com
<ul></ul><p>Gerrit Code Review wrote:</p>
<blockquote>
<p>Patch set 1 for branch <strong>TYPO3_4-5</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/33308">http://review.typo3.org/33308</a></p>
</blockquote>
<p>Hello Helmut,</p>
<p>thanks for the really quick fix, I owe you a beer next time we meet ;)</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=2328152014-10-14T23:30:31ZHelmut Hummeltypo3@helhum.io
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="[TASK] Optimize speed for instantiating class with arguments PHP reflection has quite an overhea..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/5c8081ad4487a66bad333149c65fe706106ad938">5c8081ad4487a66bad333149c65fe706106ad938</a>.</p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=2335222014-10-22T12:12:06ZMarkus Kleinmarkus.klein@typo3.org
<ul></ul><p>This introduced a regression in 4.5; The change is not PHP 5.2 (!) compatible, see <a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: TYPO3 4.5.37 requires PHP 5.3 (Closed)" href="http://forge.typo3.org/issues/62391">#62391</a></p> TYPO3 Core - Bug #53682: Exception '$toolbarItem "shortcuts" must implement interface ...\ToolbarItemHookInterface'http://forge.typo3.org/issues/53682?journal_id=3835342018-10-02T12:08:49ZBenni Mackbenni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>