Task #5658

Inconsistent class names in sub namespaces (Part II)

Added by Robert Lemke over 12 years ago. Updated over 11 years ago.

Status:
Resolved
Priority:
Must have
Assignee:
Robert Lemke
Category:
-
Target version:
TYPO3 Flow Base Distribution - 1.0 alpha 7
Start date:
2009-01-26
Due date:
% Done:

100%

Estimated time:
Sprint:
PHP Version:
Has patch:
Complexity:

Description

From the refactoring before alpha1 there are still a few edge cases concerning the naming of classes which turned out to be disturbing. Especially the rule "the main purpose of namespaces is categorization and ordering" was a bit neglected by allowing these special cases.

Currently allowed edge case           Future class name
-----------------------------------------------------------------------------------------
\F3\FLOW3\Object\Manager              \F3\FLOW3\Object\ObjectManager
\F3\Foo\Bar\Builder                   \F3\Foo\Bar\BarBuilder
\F3\FLOW3\Object\Factory              \F3\FLOW3\Object\Factory
To be discussed:
  • Rename "AbstractFoo" to "FooAbstract"
  • Rename "InvalidFoo" to "InvalidFooException"
Scope of this ticket:
  1. Refactor class names which don't follow the above rules.
  2. Add the above rules to the CGL.

Files

migrateclassnames.php (20.3 KB) migrateclassnames.php Robert Lemke, 2010-01-15 15:53
#1

Updated by Robert Lemke over 12 years ago

  • Status changed from New to Accepted
  • Target version set to 1.0 alpha 7
#2

Updated by Robert Lemke over 12 years ago

  • % Done changed from 100 to 50
#3

Updated by Robert Lemke over 12 years ago

Attached script which I used to migrate the class names of the FLOW3 Base distribution.

#4

Updated by Robert Lemke over 12 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 50 to 100

Applied in changeset r3643.

Also available in: Atom PDF