Bug #56825

Image rendering fails after ShowPic patch (#56723)

Added by Alexander Stehlik about 6 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2014-03-12
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Since the patch for integrating FAL in the ShowPic functions was commited image rendering fails if lightboxes are enabled in the constants.

The reason seems to be that a file object is passed to the IMG_RESOURCE content object but it only can handle files / uids.


Related issues

Related to TYPO3 Core - Bug #56723: Image click-enlarge doesn't use the File Abstraction Layer Closed 2014-03-10

Associated revisions

Revision df8672fb (diff)
Added by Alexander Stehlik about 6 years ago

[BUGFIX] Fix resource handling in image rendering

The image rendering configuration of css_styled content is fixed so
that the image reference is correctly passed on through all further
methods.

The IMG_RESOURCE content object also accepts file or file reference
objects and will only pass on the file to TemplateService::getFileName()
if GIFBUILDER is used to prevent PHP warnings.

This fixes the image rendering after the imageLinkWrap function was
made FAL aware in #56723.

Releases: 6.2
Resolves: #56825
Change-Id: Ie6b0261de40b25aab26740b4d889a1eebc3e7a8c
Reviewed-on: https://review.typo3.org/28305
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

History

#1 Updated by Gerrit Code Review about 6 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28305

#2 Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28305

#3 Updated by Alexander Stehlik about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF