Task #56833
closedLocking around fwrite is not needed in append mode
100%
Description
There are several calls in the TYPO3 core that use locking around files opened in append note to write using fwrite.
According to the PHP documentation, fwrite is atomic on local file systems.
If handle was fopen()ed in append mode, fwrite()s are atomic (unless the size of string exceeds the filesystem's block size, on some platforms, and as long as the file is on a local filesystem). That is, there is no need to flock() a resource before calling fwrite(); all of the data will be written without interruption.
Unneeded:
GeneralUtility:syslog()
GeneralUtility:deprecationLog()
it should stay in:
MboxTransport::send()
Updated by Gerrit Code Review over 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28312
Updated by Philipp Gampe over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 18dbe118390727a5c02147872ac1a37e2bf1f68e.