http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692014-03-17T15:29:40ZTYPO3 ForgeTYPO3 Core - Task #56994: Introduce shadowColumnsForMovePlaceholders propertyhttp://forge.typo3.org/issues/56994?journal_id=2085972014-03-17T15:29:40ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/28473">https://review.typo3.org/28473</a></p> TYPO3 Core - Task #56994: Introduce shadowColumnsForMovePlaceholders propertyhttp://forge.typo3.org/issues/56994?journal_id=2086022014-03-17T16:22:18ZThorsten Kahler
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Needs Feedback</i></li></ul><p>Why do we need another config option for move placeholders? What's the difference to new placeholders in this context?</p> TYPO3 Core - Task #56994: Introduce shadowColumnsForMovePlaceholders propertyhttp://forge.typo3.org/issues/56994?journal_id=2086052014-03-17T16:37:59ZTimo Weblertimo.webler@dkd.de
<ul></ul><p>Available changes for move placeholder:</p>
<ul>
<li><a class="issue tracker-1 status-5 priority-4 priority-default closed child" title="Bug: Backend workspace copy/cut paste column content fails on publish (Closed)" href="http://forge.typo3.org/issues/32967">#32967</a></li>
<li><a class="external" href="https://review.typo3.org/18107">https://review.typo3.org/18107</a></li>
</ul> TYPO3 Core - Task #56994: Introduce shadowColumnsForMovePlaceholders propertyhttp://forge.typo3.org/issues/56994?journal_id=2086112014-03-17T17:07:53ZOliver Haderoliver.hader@typo3.org
<ul></ul><p>Thorsten Kahler wrote:</p>
<blockquote>
<p>Why do we need another config option for move placeholders? What's the difference to new placeholders in this context?</p>
</blockquote>
<p>The difference is "it is used for move placeholders" only... as written...</p>
<p>The reason for that is the way move-placeholders are overlaid in the frontend.<br />See <a class="external" href="https://review.typo3.org/#/c/27774/">https://review.typo3.org/#/c/27774/</a> and the accordant CSV tests on sorting/moving things...</p> TYPO3 Core - Task #56994: Introduce shadowColumnsForMovePlaceholders propertyhttp://forge.typo3.org/issues/56994?journal_id=2086192014-03-17T18:26:04ZOliver Haderoliver.hader@typo3.org
<ul></ul><p>Timo Webler wrote:</p>
<blockquote>
<p>Available changes for move placeholder:</p>
<ul>
<li><a class="issue tracker-1 status-5 priority-4 priority-default closed child" title="Bug: Backend workspace copy/cut paste column content fails on publish (Closed)" href="http://forge.typo3.org/issues/32967">#32967</a></li>
<li><a class="external" href="https://review.typo3.org/18107">https://review.typo3.org/18107</a></li>
</ul>
</blockquote>
For IRRE that's not enough - the action happens in DataHandlerHook::moveRecord
<ul>
<li>DataHandler::versionizeRecord (creates version and the new placeholder)</li>
<li>DataHanderHook::moveRecord_wsPlaceholders (creates move placeholder after everything was processed and remapped (remapStack))</li>
</ul>
I've applied your patch locally and disable the new movePlaceHolder property - the TravisCI test fail
<ul>
<li><a class="external" href="https://travis-ci.org/ohader/TYPO3.CMS/jobs/20950988">https://travis-ci.org/ohader/TYPO3.CMS/jobs/20950988</a> (the expected values are not set, thus misusing the newPlaceHolder property is not enough)</li>
<li><a class="external" href="https://travis-ci.org/ohader/TYPO3.CMS/jobs/20951081">https://travis-ci.org/ohader/TYPO3.CMS/jobs/20951081</a> (disabled the DataSet assertions - thus behaviour in frontend is not as expected)</li>
</ul> TYPO3 Core - Task #56994: Introduce shadowColumnsForMovePlaceholders propertyhttp://forge.typo3.org/issues/56994?journal_id=2086852014-03-17T23:33:20ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>Needs Feedback</i> to <i>Under Review</i></li></ul><p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/28473">https://review.typo3.org/28473</a></p> TYPO3 Core - Task #56994: Introduce shadowColumnsForMovePlaceholders propertyhttp://forge.typo3.org/issues/56994?journal_id=2086962014-03-18T08:52:43ZOliver Haderoliver.hader@typo3.org
<ul></ul><p>Gerrit Code Review wrote:</p>
<blockquote>
<p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/28473">https://review.typo3.org/28473</a></p>
</blockquote>
<p>This change combines the new property for "move" with the old property for "new" as a fallback...<br />Thus, one can decide whether to override/disable on demand.</p> TYPO3 Core - Task #56994: Introduce shadowColumnsForMovePlaceholders propertyhttp://forge.typo3.org/issues/56994?journal_id=2088732014-03-18T22:33:22ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/28473">https://review.typo3.org/28473</a></p> TYPO3 Core - Task #56994: Introduce shadowColumnsForMovePlaceholders propertyhttp://forge.typo3.org/issues/56994?journal_id=2088832014-03-18T23:32:11ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/28473">https://review.typo3.org/28473</a></p> TYPO3 Core - Task #56994: Introduce shadowColumnsForMovePlaceholders propertyhttp://forge.typo3.org/issues/56994?journal_id=2095922014-03-21T20:06:56ZGerrit Code Review
<ul></ul><p>Patch set 5 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/28473">https://review.typo3.org/28473</a></p> TYPO3 Core - Task #56994: Introduce shadowColumnsForMovePlaceholders propertyhttp://forge.typo3.org/issues/56994?journal_id=2096062014-03-21T20:30:48ZOliver Haderoliver.hader@typo3.org
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[FEATURE] Introduce shadowColumnsForMovePlaceholders property $TCA[<table>]['ctrl']['shadowColum..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/6e9fd7da1b26e2860d4ce9ee9dd01f666d89be34">6e9fd7da1b26e2860d4ce9ee9dd01f666d89be34</a>.</p> TYPO3 Core - Task #56994: Introduce shadowColumnsForMovePlaceholders propertyhttp://forge.typo3.org/issues/56994?journal_id=3828642018-10-02T11:58:03ZBenni Mackbenni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>