Feature #60095

LockManager's LockHoldingStackPage should be configurable

Added by Kevin Fischer about 7 years ago. Updated about 7 years ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Configuration
Target version:
-
Start date:
2014-07-04
Due date:
% Done:

0%

Estimated time:
PHP Version:
Has patch:
No
Complexity:
easy

Description

In the LockManager's current implementation, the file to be displayed when Flow is locked sadly is hard-coded on line 101:

readfile(FLOW_PATH_FLOW . 'Resources/Private/Core/LockHoldingStackPage.html');

This should be configurable and could be implemented like so in TYPO3.Flow's Settings.yaml:

TYPO3:
  Flow:
    core:
      lockHoldingStackPage: 'resource://TYPO3.Flow/Private/Core/LockHoldingStackPage.html'

#1

Updated by Alexander Berl about 7 years ago

I think it would be nice if that page could be configured like the other errorpages via the renderingGroups configuration.
However, there are a few issues with that:

1.) In the essential bootstrap, initializeErrorHandling would have to be put before initializeLockManager - should be no problem, no?
2.) Every request to a locked site would also create an exception log entry (including dump) - is that feasible?
3.) The usage of 'resource://' will not be easily possible, as the resource management and resource wrapper is initialized much later than the lockmanager - this is a major issue against using renderingGroups

I'll push a change that adds the simple configuration setting as above for the time being.

#2

Updated by Gerrit Code Review about 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/31433

Also available in: Atom PDF