Bug #62104: LocalDriver::getFileInfoByIdentifier can be optimised - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #62104

closed

LocalDriver::getFileInfoByIdentifier can be optimised

Added by Michiel Roos over 9 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

Start date:

2014-10-08

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

\TYPO3\CMS\Core\Resource\Driver\LocalDriver::getFileInfoByIdentifier() fetches the dirPath of the given $fileIdentifier at the start of the method.

This information is not used untill the last line of the method.

The method may fail if the resource does not exist. By that time, some work was performed that was not needed.

I suggest moving the $dirPath calculation to the bottom of the method.

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34006

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34006

Actions

Copy link