Bug #62104
closed
LocalDriver::getFileInfoByIdentifier can be optimised
100%
Description
\TYPO3\CMS\Core\Resource\Driver\LocalDriver::getFileInfoByIdentifier() fetches the dirPath of the given $fileIdentifier at the start of the method.
This information is not used untill the last line of the method.
The method may fail if the resource does not exist. By that time, some work was performed that was not needed.
I suggest moving the $dirPath calculation to the bottom of the method.
Updated by Gerrit Code Review about 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34006
Updated by Gerrit Code Review almost 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34006
Updated by Frederic Gaus almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 9ca5e3b16d5d3708d4abbce8123966239b1d334e.
Updated by