Bug #62280: css_styled_content include via INCLUDE_TYPOSCRIPT still not working correctly (removes closing bracket "}") - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #62280

closed

css_styled_content include via INCLUDE_TYPOSCRIPT still not working correctly (removes closing bracket "}")

Added by Andreas Allacher about 10 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Target version:

Start date:

2014-10-16

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

With https://forge.typo3.org/issues/49461
support was added to allow css_styled_content to be loaded via INCLUDE_TYPOSCRIPT.
However, that is still buggy.

see code:
https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php#l808

The problem is the soon following

// Not the first/last linebreak char.
$string = substr($newString, 1, -1);

Because TYPO3\CMS\Extbase\Utility\ExtensionUtility->configurePlugin does not add a linebreak add the end this causes the closing "}" to be removed which is a problem if TypoScript comes afterwards.

Actions

Copy link

Updated by Andreas Allacher about 10 years ago

I am not even sure why we try to remove the new lines at this point but if so wouldn't something like this:
trim($newString, LF);
Maybe also with CR
be a better solution?

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37038

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37038

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37038

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37038

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37038

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37038

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37038

Actions

Copy link

Updated by Andreas Allacher over 9 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 40115724193d1205d1a4aea54251de859d1e4351.

Actions

Copy link

#10

Updated by Gerrit Code Review about 9 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44724

Actions

Copy link

#11