Task #6591
Refactor F3\FLOW3\Log\Backend\FileBackend : getFormattedVarDump
Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
Log
Target version:
-
Start date:
Due date:
% Done:
50%
Estimated time:
Sprint:
PHP Version:
Has patch:
No
Complexity:
Description
Hi,
I did (my first) refactoring with this function.
Now:- Smaller
- Less control structures,
- Logic outlines the similarities of an array and an object (to nest) -> I think easier to understand and more consistent
The 'big' change is in fact that I add afterwards the keys of the array/names of the properties. Before we looked after every possibility extra!
A Question:
Why this limitation with the 100 spaces?
Files
Updated by Karsten Dambekalns over 10 years ago
- Status changed from Needs Feedback to On Hold
- Start date deleted (
2010-02-24)
You need to sign the CLA before we can accept your contribution, see http://typo3.org/about/licenses
Updated by Christian Müller almost 9 years ago
- Status changed from On Hold to Rejected
- Has patch set to No
In the meantime the method has changed quite a lot and the limit IMHO makes sense otherwise the output will totally break out. It would probably make sense to log smaller chunks of data if you hit this limit. Reopen if you have a good use-case to change the limit.