Project

General

Profile

Actions

Bug #67703

closed

No logging to sysLog in ExceptionHandler

Added by Felix Nagel almost 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2015-06-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The sysext/core/Classes/Error/AbstractExceptionHandler.php class has a writeLog method which should write new entries to the sys_log table. It seems this is broken.

Within the method there is a check for proper DB connection:

if (is_object($GLOBALS['TYPO3_DB']) && !empty($GLOBALS['TYPO3_DB']->link)) {

The second check for link will always fail as the link property of TYPO3\CMS\Core\Database\DatabaseConnection is protected.
Perhaps this was caused due to a visibility change?

This should be handled like in typo3/sysext/core/Classes/Error/ErrorHandler.php

if (is_object($GLOBALS['TYPO3_DB']) && $GLOBALS['TYPO3_DB']->isConnected()) {

Tested in TYPO3 CMS 6.2.12 and 7.3

Actions #1

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40565

Actions #2

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40565

Actions #3

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40565

Actions #4

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40608

Actions #5

Updated by Mathias Schreiber almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Teams/Security/TYPO3v4-Core has been pushed to the review server.
It is available at http://review.typo3.org/40633

Actions #7

Updated by Alexander Opitz almost 9 years ago

  • Status changed from Under Review to Resolved

Reopened by accident.

Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF