Bug #68423: Use parse_url to determine fully qualified urls in ImageService - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #68423

closed

Use parse_url to determine fully qualified urls in ImageService

Added by Frans Saris over 9 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Frans Saris

Category:

Target version:

Start date:

2015-07-21

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

In de ImageService strpos($imageUrl, '://') is used to check if the url is already a absolute url. But because in HTML context/output the schema isn't needed for images this check will fail for //www.my-domain.com/image.jpg.

To also support only // we should use parse_url($imageUrl, PHP_URL_HOST) !== NULL to check if it is an absolute url.

Actions

Copy link

Updated by Frans Saris over 9 years ago

Description updated (diff)

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41771

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41771

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41771

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41777

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41777

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41777

Actions

Copy link

Updated by Frans Saris over 9 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 4e169b7637c28082273431abc03f892d7c3cb2f3.

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Status changed from Resolved to Under Review

Patch set 4 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41777

Actions

Copy link

#10