Bug #68423
closed
Use parse_url to determine fully qualified urls in ImageService
Added by Frans Saris over 9 years ago.
Updated about 6 years ago.
Description
In de ImageService strpos($imageUrl, '://')
is used to check if the url is already a absolute url. But because in HTML context/output the schema isn't needed for images this check will fail for //www.my-domain.com/image.jpg
.
To also support only //
we should use parse_url($imageUrl, PHP_URL_HOST) !== NULL
to check if it is an absolute url.
- Description updated (diff)
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41771
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41771
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41771
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41777
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41777
Patch set 3 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41777
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Under Review
Patch set 4 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41777
- Status changed from Under Review to Resolved
- Status changed from Resolved to Closed
Also available in: Atom
PDF