Project

General

Profile

Actions

Bug #70488

closed

f:form.submit creates invalid HTML

Added by Alex Kellner over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2015-10-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Because of #70486 we found a strange behaviour of submit buttons which are rendered from through <f:form.submit />.
It it seems that there is a problem with empty name attributes in submit buttons.

Using a submit ViewHelper like this:

<f:form.submit value="submit now" />

Leads to a HTML:

<input type="submit" value="submit now" name="" />

Following W3C (see https://validator.w3.org/nu/#textarea) it's ok to have a submit button without a name attribute, but it's not ok to have an empty name attribute.
If someone wants to send an additional value, you can use the name attribute with a value, but in most of all use-cases a name attribute is not needed in the submit button.
We need to disable the rendering of empty name attributes.

Actions #1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/44135

Actions #2

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/44135

Actions #3

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/44135

Actions #4

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/44135

Actions #5

Updated by Anonymous over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF