Bug #71562
closed
be.infobox viewHelper can't render success messages because of usage of MathUtility::forceIntegerInRange()
100%
Description
<f:be.infobox message="..." state="0" /> should output a success message (STATE_OK), but STATE_NOTICE (-2) is rendered.
The param state ic checked using $state = MathUtility::forceIntegerInRange($arguments['state'], -2, 2, -2); which always returns the default value (-2) if state is 0 (zero).
Imho it's a bug in MathUtility::forceIntegerInRange(). At the moment the given value in always replaced by the default value if it's zero and thus it's impossible to test zero values.
Updated by Felix Kopp almost 9 years ago
can be seen in EXT: styleguide also. positive infobox with state=0 not possible
Updated by Gerrit Code Review almost 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45652
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45652
Updated by Gerrit Code Review almost 9 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45683
Updated by Wouter Wolters almost 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset db44503e2a86eed573b303b4b54f453c0fbeea5b.
Updated by