Project

General

Profile

Actions

Feature #72648

closed

Automatically remove BOM in css files before concatenation

Added by Christian Futterlieb over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2016-01-12
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

When css files contain a BOM (https://en.wikipedia.org/wiki/Byte_order_mark), it must be removed. Because when the BOM does not occur on the beginning of a file, it will be interpreted as a normal character, which will make the following css rule invalid.

There is a corresponding warning in the documentation (https://wiki.typo3.org/UTF-8_support#File_system), but the subsequent problems (when a css file contains a BOM) are tricky to track down and even trickier to fix. Because of this I think people will stick with excludeFromConcatenation, or - even worse - with config.concatenateCss = 0

I'll commit a possible solution to gerrit in a moment.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #72734: Fix messed up backport usage of StringUtilityClosedAnja Leichsenring2016-01-15

Actions
Actions #1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45842

Actions #2

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45842

Actions #3

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45842

Actions #4

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45842

Actions #5

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45842

Actions #6

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45936

Actions #7

Updated by Christian Futterlieb over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45938

Actions #9

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45938

Actions #10

Updated by Christian Futterlieb over 8 years ago

  • Status changed from Under Review to Resolved
Actions #11

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF