http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692016-03-01T20:04:50ZTYPO3 ForgeTYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=2984052016-03-01T20:04:50ZWouter Wolterstypo3@wouterwolters.nl
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Accepted</i></li><li><strong>Assignee</strong> deleted (<del><i>Benni Mack</i></del>)</li></ul><p>Confirmed.</p> TYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=3009872016-04-05T11:09:36ZTeamgeist Medienweb@teamgeist-medien.de
<ul></ul><p>SOLUTION</p>
<p>Bind a "current" argument to the ViewHelper to provide the ContentObject UID.</p>
<p>In ClickEnlargeViewHelper.php</p>
<p>Add</p>
<pre>
$this->registerArgument('current', 'integer', 'The Content Object UID', false);
</pre>
<p>To the initializeArguments() function.</p>
<p>Then add this to the renderStatic() function:</p>
<pre>
if (isset($arguments['current'])) {
self::getContentObjectRenderer()->setCurrentVal($arguments['current']);
}
</pre>
<p>Now call the ViewHelper like this:</p>
<pre>
<ce:link.clickEnlarge image="{column.media}" configuration="{settings.media.popup}" current="{data.uid}">
</pre>
<p><strong>And change the constant to lightbox[{current}]</strong></p> TYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=3009882016-04-05T11:16:16ZTeamgeist Medienweb@teamgeist-medien.de
<ul></ul><p>Sorry I'm not familiar with Gerrit, yet. Hope someone else can push this to Gerrit... <br />The argument "current" in the ViewHelper maybe also should be renamed to "contentObjectUid"</p> TYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=3057042016-05-30T16:41:13ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/48406">https://review.typo3.org/48406</a></p> TYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=3057092016-05-30T17:02:42ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/48406">https://review.typo3.org/48406</a></p> TYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=3057162016-05-30T18:10:22ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/48406">https://review.typo3.org/48406</a></p> TYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=3062632016-06-07T16:56:31ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/48406">https://review.typo3.org/48406</a></p> TYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=3062732016-06-07T17:32:33ZGerrit Code Review
<ul></ul><p>Patch set 5 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/48406">https://review.typo3.org/48406</a></p> TYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=3259342017-03-05T10:43:28ZTorben Hansenderhansen@gmail.com
<ul></ul><p>The problem still exists in the current master branch. IMO the problem should be fixed for 8.7 LTS, since grouping of lightbox images is currently broken in Fluid Styled Content. The existing patch contains breaking changes, so maybe it is better to fix the bug with non-breaking changes.</p> TYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=3327522017-05-14T12:55:23ZDirk Klimpeldirk@klimpel.org
<ul></ul><p>Is it real a bug of "fluid_styled_content"? And not a bug of fluid?<br />With "field:uid" I should get the id of the content element. But i get the id of the page.</p>
<p>I get the following results:<br />"field:uid" - id of the page, should get the id of the element<br />"field:pid" - id of the parent page, should get the id of the page<br />"field:header" - nothing, should get the headline<br />"page:uid" - id of the page - right<br />"page:pid" - id of the parent page - right<br />"page:title" - page title - right</p> TYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=3373772017-07-27T12:48:50ZAnonymous
<ul></ul><p>TypoScript to the rescue! Here's a <a href="https://gist.github.com/Kitzberger/acfc630c0ea9a430c875af3fbe79a724" class="external">workaround</a> for TYPO3 8.7:<br /><pre>
lib.contentElement.variables.10 = LOAD_REGISTER
lib.contentElement.variables.10.content_uid = TEXT
lib.contentElement.variables.10.content_uid.field = uid
lib.contentElement.settings.media.popup.linkParams.ATagParams.dataWrap = class="{$styles.content.textmedia.linkWrap.lightboxCssClass}" rel="{$styles.content.textmedia.linkWrap.lightboxRelAttribute}[{register:content_uid}]"
lib.contentElement.stdWrap.append = RESTORE_REGISTER
</pre></p> TYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=3514902017-11-24T22:28:07ZBenni Mackbenni@typo3.org
<ul><li><strong>Sprint Focus</strong> set to <i>On Location Sprint</i></li></ul> TYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=3519362017-11-28T13:47:14ZBenjamin Kottbenjamin.kott@outlook.com
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Rejected</i></li></ul><p>This patch is highly breaking for everyone relying on this, since there is no universal implementation for this and its always relying on JavaScript in the end i will abandon this patchset as there is no real benefit, and only may work in one specific usecase.</p>
<p>For reference and example how to make your implementation work, please see implementation of the bootstrap_package<br /><a class="external" href="https://github.com/benjaminkott/bootstrap_package/blob/master/Resources/Private/Partials/ContentElements/Media/Type/Image.html#L10-L19">https://github.com/benjaminkott/bootstrap_package/blob/master/Resources/Private/Partials/ContentElements/Media/Type/Image.html#L10-L19</a></p> TYPO3 Core - Bug #72779: Lightbox : grouping imageshttp://forge.typo3.org/issues/72779?journal_id=3562442018-01-29T16:02:52ZDirk Klimpeldirk@klimpel.org
<ul></ul><p>The solution is:<br /><pre><code>lib.fluidContent.settings.media.popup.linkParams.ATagParams.dataWrap = class="lightbox" rel="lightbox[{file:current:uid_foreign}]"
</code></pre></p>
<p><strong>{file:current:uid_foreign}</strong> gives the id of content element.</p>
<p>See also: <a class="external" href="https://forum.typo3.org/index.php?t=rview&goto=753239#msg_753239">https://forum.typo3.org/index.php?t=rview&goto=753239#msg_753239</a></p>