Task #76082
closed
Improve readability of the TypoScript Parser - the lastCondition flag
0%
Description
TYPO3\CMS\Core\TypoScript\Parser\TypoScriptParser
- The public flag $lastConditionTrue controls if the [ELSE] branch is selected, when the previous condition failed. The term last is ambiguous.
- This semantic message shall be expressed in a change of the wording: $previousConditionFailed
- The flag is public, but it's functionality scope is internal.
- Set it protected.
- Booleans aret int.
- Set to bool.
- Do related cleanups.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from New to Under Review
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48038
Updated by Gerrit Code Review almost 8 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48038
Updated by Gerrit Code Review almost 8 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48038
Updated by Gerrit Code Review almost 8 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48038
Updated by Gerrit Code Review almost 8 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48038
Updated by Gerrit Code Review almost 8 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48038
Updated by Anja Leichsenring almost 6 years ago
- Status changed from Under Review to Rejected