Project

General

Profile

Actions

Bug #76201

closed

sysext:frontend: config.disableBodyTag removes <body>, but not </body>

Added by Martin Bless almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2016-05-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The following feels like a bug: TypoScript setting config.disableBodyTag indeed removes the opening <body ...> tag but not the closing part </body>. For example with FLUIDTEMPLATE it can be nice to put the whole <body> ... </body> sequence into the HTML layout template. It would look like an error if you leave out the </body> part there. But if you keep it you end up with a duplicate closing body tag and, depending, with two times the code for the admin panel, which makes it unusable.

See https://docs.typo3.org/typo3cms/TyposcriptReference/Setup/Config/Index.html?highlight=disablebodytag#disablebodytag

Actions #1

Updated by Wouter Wolters almost 8 years ago

IMO this is not a bug. The description of this option clearly states that it remove <body> and not </body>. Furthermore it takes precedence over a couple of other options that only affect the <body> tag and not the closing body-tag.

The option is meant to provide a way to add additional attributes, these are nog possible on the closing tag.

Actions #2

Updated by Martin Bless almost 8 years ago

Wouter Wolters wrote:

IMO this is not a bug.

Conclusion:

Having thought about this I agree in the end. Let's just close the ticket.

Reasoning:

The description of this option clearly states that it remove <body> and not </body>.

This is where I disagree. The name "disableBodyTag" and the current description appear to be misleading to me. In html context to disable a tag affects opening and closing clause of tag of course.

Furthermore it takes precedence over a couple of other options that only affect the <body> tag and not the closing body-tag. The option is meant to provide a way to add additional attributes, these are nog possible on the closing tag.

Yes, but you can't easily find that information just by reading.

More important seems to me: We can't change behaviour without breaking backwards compatibility. And probably nobody will be willing to introduce something new like "config.disableBodyTagREALLY".

Solution:

I'll make the description in the docs clearer.

Actions #3

Updated by Wouter Wolters almost 8 years ago

  • Status changed from New to Closed

Thanks for updating the docs to make things more clear here. I close this issue now as solved.

Actions

Also available in: Atom PDF