Task #76885
closed
Be more verbose about errors when copying pages
100%
Description
Affected use case: copy and insert a page in the backend's page tree.
\TYPO3\CMS\Core\DataHandling\DataHandler::copyRecord contains a set of error messages which are logged when copying a record fails.
As it turns out, it would be of great benefit for debugging problems in respect to extensions if the logged output would be more verbose which extension's table record actually was the origin of the error. Especially if a lot of extensions come into play.
Files
Updated by Thomas Mayer over 8 years ago
Example:
https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_6-2/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L3211
https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_7-6/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L3439
https://github.com/mblaschke/TYPO3-metaseo/issues/247
Messages should at least contain the affected table like
$this->log($table, $uid, 3, 0, 1, 'Attempt to insert record "' . $table . '" on a page that can\'t store record type.');
As soon as the table name is part of the message, the user can see the extension's name via the table's prefix.
I can create a patch, but I should know against which target version I can patch against (6.2/7.6/master). I'd prefer 6.2 or 7.6.
Updated by Thomas Mayer over 8 years ago
- File log_entry.png log_entry.png added
- File log_entry.png log_entry.png added
Screenshot: Log entry and error message tell nothing about the affected extension.
Updated by Gerrit Code Review over 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48741
Updated by Gerrit Code Review over 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48741
Updated by Gerrit Code Review over 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48741
Updated by Gerrit Code Review over 8 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49227
Updated by Benni Mack over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1689235f45f5716fd2fa312adb09777a50ddc3e6.