Task #77415
closed
Revert "[TASK] Show case sensitive command identifier"
100%
Description
Revert "[TASK] Show case sensitive command identifier"
Updated by Gerrit Code Review over 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49387
Updated by Mathias Brodala over 8 years ago
Please add an explanation why this is necessary.
Updated by Wouter Wolters over 8 years ago
Helmut Hummel
Aug 1 18:20
Patch Set 2:
post -1
First of all, this is a breaking change! There are other extensions using this API and they now get a different identifier back than before.
second: which commands are not readable? these should be shortened instead.
imho showing cased identifiers while accepting any casing is confusing at least.
besides that: this commit broke the special handling of the "help" command, which is now shown as "Help:help"
Helmut Hummel
Aug 1 18:24
Patch Set 2:
is there any command line tool, that uses cased command identifiers? I know none.
making TYPO3 exceptional here (again)?
Helmut Hummel
Aug 1 18:26
Patch Set 2:
and on top: it might make things more complicated for the future. previously the only official command was lowercased (although wrong casing was accepted). Now we officially support different casing for commands. symfony console does not
Benni Mack
Aug 2 08:00
Patch Set 2:
wow. thanks for the analysis. did not see this gravital impact, and I opt for reverting. @georg OK?
Helmut Hummel
Aug 2 13:02
Patch Set 2:
For better readability, I would suggest the following change: https://github.com/TYPO3-Console/typo3_console/issues/270
I have a PoC ready for typo3 console and it works like a charm.
Updated by Wouter Wolters over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 5f58ab2357774f22cb8d9e0d3ed6db168960eb88.
Updated by