Bug #77577

Source collection images don't get resized if file = GIFBUILDER

Added by Marco Huber about 3 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2016-08-22
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If you use a GIFBUILDER object as file resource in an IMAGE object, the images in the source collection don't get resized.

10 = IMAGE
10 {
  file = GIFBUILDER
  file {
    XY = 400,350
    ...
  }
  sourceCollection {
    small.width = 320
    small.mediaQuery = (min-width: 260px)

    medium.width = 400
    medium.mediaQuery = (min-width: 360px)
  }
}

Associated revisions

Revision 4dead4b5 (diff)
Added by Marco Huber over 1 year ago

[BUGFIX] Fix source collection for GIFBUILDER

If the file resource is a GIFBUILDER object, the dimension is set in the
properties XY, maxWidth or maxHeight.

Change-Id: Ic931760a966e6647042bca976c48e7bbaabdbb5a
Resolves: #77577
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/49537
Tested-by: TYPO3com <>
Reviewed-by: Łukasz Uznański <>
Reviewed-by: Tomas Norre Mikkelsen <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>
Tested-by: Susanne Moog <>

Revision 7427f11c (diff)
Added by Marco Huber over 1 year ago

[BUGFIX] Fix source collection for GIFBUILDER

If the file resource is a GIFBUILDER object, the dimension is set in the
properties XY, maxWidth or maxHeight.

Change-Id: Ic931760a966e6647042bca976c48e7bbaabdbb5a
Resolves: #77577
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55817
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

#2 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

#3 Updated by Marco Huber about 3 years ago

With the patch you can use

10 = IMAGE
10 {
  file = GIFBUILDER
  file {
    XY = 400,350
    ...
  }
  sourceCollection {
    small.XY = 320,280
    small.mediaQuery = (min-width: 260px)

    medium.XY = 400,350
    medium.mediaQuery = (min-width: 360px)
  }
}

#4 Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

#5 Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

#6 Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

#7 Updated by Marco Huber almost 3 years ago

New Tests:

page >
page = PAGE
page {
  10 = IMAGE
  10 {
    file = GIFBUILDER
    file {
      XY = 400,500
      maxWidth = 200
      maxHeight = 300
      backColor = #000000
    }
    layoutKey = picture
    layout.picture.element = <ul>###SOURCECOLLECTION###</ul>
    layout.picture.source = <li>###WIDTH###*###HEIGHT### <img src="###SRC###" media="###MEDIAQUERY###" ###PARAMS### ###ALTPARAMS### data-width="###WIDTH###" data-height="###HEIGHT###" ###SELFCLOSINGTAGSLASH###></li>
    sourceCollection {
      # expect an image with 200*300
      default.mediaQuery = (min-device-width: 800px)

      # expect an image with 180*280
      changeXY.XY = 180,280
      changeXY.mediaQuery = (min-device-width: 800px)

      # expect an image with 150*250
      limitWidthAndHeight.maxWidth = 150
      limitWidthAndHeight.maxHeight = 250      
      limitWidthAndHeight.mediaQuery = (min-device-width: 800px)

      # expect an image with 50*100
      changeXYAndLimitWidhtAndHeight.XY = 150,250
      changeXYAndLimitWidhtAndHeight.maxWidth = 50
      changeXYAndLimitWidhtAndHeight.maxHeight = 100
      changeXYAndLimitWidhtAndHeight.mediaQuery = (min-device-width: 800px)
    }
  }
}

#8 Updated by Gerrit Code Review almost 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

#9 Updated by Gerrit Code Review almost 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

#10 Updated by Benni Mack almost 2 years ago

  • Sprint Focus set to On Location Sprint

#11 Updated by Gerrit Code Review almost 2 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

#12 Updated by Marco Huber over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#13 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55817

#14 Updated by Marco Huber over 1 year ago

  • Status changed from Under Review to Resolved

#15 Updated by Mathias Brodala over 1 year ago

  • Sprint Focus deleted (On Location Sprint)

#16 Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF