Bug #77577: Source collection images don't get resized if file = GIFBUILDER - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #77577

closed

Source collection images don't get resized if file = GIFBUILDER

Added by Marco Huber over 7 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

Start date:

2016-08-22

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

If you use a GIFBUILDER object as file resource in an IMAGE object, the images in the source collection don't get resized.

10 = IMAGE
10 {
  file = GIFBUILDER
  file {
    XY = 400,350
    ...
  }
  sourceCollection {
    small.width = 320
    small.mediaQuery = (min-width: 260px)

    medium.width = 400
    medium.mediaQuery = (min-width: 360px)
  }
}

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

Actions

Copy link

Updated by Marco Huber over 7 years ago

With the patch you can use

10 = IMAGE
10 {
  file = GIFBUILDER
  file {
    XY = 400,350
    ...
  }
  sourceCollection {
    small.XY = 320,280
    small.mediaQuery = (min-width: 260px)

    medium.XY = 400,350
    medium.mediaQuery = (min-width: 360px)
  }
}

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

Actions

Copy link

Updated by Marco Huber over 7 years ago

New Tests:

page >
page = PAGE
page {
  10 = IMAGE
  10 {
    file = GIFBUILDER
    file {
      XY = 400,500
      maxWidth = 200
      maxHeight = 300
      backColor = #000000
    }
    layoutKey = picture
    layout.picture.element = <ul>###SOURCECOLLECTION###</ul>
    layout.picture.source = <li>###WIDTH###*###HEIGHT### <img src="###SRC###" media="###MEDIAQUERY###" ###PARAMS### ###ALTPARAMS### data-width="###WIDTH###" data-height="###HEIGHT###" ###SELFCLOSINGTAGSLASH###></li>
    sourceCollection {
      # expect an image with 200*300
      default.mediaQuery = (min-device-width: 800px)

      # expect an image with 180*280
      changeXY.XY = 180,280
      changeXY.mediaQuery = (min-device-width: 800px)

      # expect an image with 150*250
      limitWidthAndHeight.maxWidth = 150
      limitWidthAndHeight.maxHeight = 250      
      limitWidthAndHeight.mediaQuery = (min-device-width: 800px)

      # expect an image with 50*100
      changeXYAndLimitWidhtAndHeight.XY = 150,250
      changeXYAndLimitWidhtAndHeight.maxWidth = 50
      changeXYAndLimitWidhtAndHeight.maxHeight = 100
      changeXYAndLimitWidhtAndHeight.mediaQuery = (min-device-width: 800px)
    }
  }
}

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

Actions

Copy link

#10

Updated by Benni Mack over 6 years ago

Sprint Focus set to On Location Sprint

Actions

Copy link

#11

Updated by Gerrit Code Review over 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49537

Actions

Copy link

#12

Updated by Marco Huber over 6 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 4dead4b53e2e91c26a820572e2fe77cfa17a5bff.

Actions

Copy link

#13

Updated by Gerrit Code Review about 6 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55817

Actions

Copy link

#14