Actions

Copy link

Bug #77943

closed

VH f:link.typolink: A unique css class could be added twice to resulting class attribute

Added by Josef Glatz about 8 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Could have

Assignee:

Category:

Fluid

Target version:

Start date:

2016-09-14

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Problem/Description¶

Requirement: {data.header_link} = t3://page?uid=15 - blocklink "My Title"

<f:link.typolink parameter="{data.header_link}" class="blocklink"></f:link.typolink>

The resulting class attribute class="blocklink blocklink"

Acceptance Criteria¶

The resulting class attribute should not contain duplicate css classes
This fix should also go into 7.6LTS and 6.2 LTS

Actions

Copy link

Updated by Josef Glatz about 8 years ago

Subject changed from VH f:link.typolink: A class could be added twice to resulting class attribute to VH f:link.typolink: A unique css class could be added twice to resulting class attribute

Actions

Copy link

Updated by Josef Glatz about 8 years ago

Description updated (diff)

Actions

Copy link

Updated by Josef Glatz about 8 years ago

Priority changed from Should have to Could have

Actions

Copy link

Updated by Claus Due about 8 years ago

This is not as simple as it may seem: the method that generates the link receives both the input and the configuration array and the result is the duplicated class. If the ViewHelper is supposed to detect and avoid this it will require parsing the "parameter" (t3:// link) to detect all classes and filter values in "class" - and I'm not sure I'm a fan of that type of processing. If the ViewHelper is not supposed to do such parsing then this issue should be moved to whichever category typoLink (the core method, not the ViewHelper) belongs to. And I would personally argue that if this detection/filtering should happen then it should happen in the typoLink method - not the ViewHelper.

Actions

Copy link

Updated by Gerrit Code Review about 8 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49949

Actions

Copy link

Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49949

Actions

Copy link

Updated by Gerrit Code Review about 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49949

Actions

Copy link

Updated by Gerrit Code Review about 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49949

Actions

Copy link

Updated by Gerrit Code Review about 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49949

Actions

Copy link

#10

Updated by Gerrit Code Review about 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49988

Actions

Copy link

#11