Task #78045

Implement DBAL inSet() for SQLite

Added by Oliver Hader about 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2016-09-22
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Sprint Focus:
On Location Sprint

Description

DBAL's ExpressionBuilder::inSet() currently does not support FIND_IN_SET for SQLite which is also not supported by the DBMS natively.
To achieve the behavior the field's value is surrounded by commas and then compared likewise to the accordant value expansion.

Associated revisions

Revision 59b684d7 (diff)
Added by Oliver Hader about 3 years ago

[TASK] Implement DBAL inSet() for SQLite

DBAL's ExpressionBuilder::inSet() currently does not support FIND_IN_SET
for SQLite which is also not supported by the DBMS natively. To achieve
the behavior the field's value is surrounded by commas and then compared
likewise to the accordant value expansion.

Resolves: #78045
Releases: master
Change-Id: Idceab827c06e4290bf5a68fb672a43110364af7d
Reviewed-on: https://review.typo3.org/50006
Tested-by: TYPO3com <>
Reviewed-by: MichaƂ Jankiewicz <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision e4c41dd9 (diff)
Added by Morton Jonuschat about 3 years ago

[FOLLOWUP][TASK] Implement DBAL inSet() for SQLite

Add an exception if named parameters are used with inSet() on SQLite,
add tests to verify the behaviors for named parameters and values that
contain the actual quote character.

Change-Id: Iac2e40d13f921d7e6dcfaeb2c86a9eedc4d8351e
Resolves: #78045
Releases: master
Reviewed-on: https://review.typo3.org/50149
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

History

#1 Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50006

#2 Updated by Jan Helke about 3 years ago

  • Sprint Focus set to On Location Sprint

#3 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50006

#4 Updated by Oliver Hader about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Gerrit Code Review about 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50149

#6 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50149

#7 Updated by Morton Jonuschat about 3 years ago

  • Status changed from Under Review to Resolved

#8 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF