Project

General

Profile

Actions
Copy link

Bug #78333

closed

Fetching configuration-comments requires comma before comment

Added by Stefan Neufeind about 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2016-10-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Reading the comments from DefaultConfiguration.php always requires a comma after the value and before the comment. But CGL seems to suggest that for the last element in an array no trailing comma is used. (The bamboo-CGL-check on review.typo3.org complained about that.)

The reason is a regex in Classes/Controller/Action/Tool/AllConfiguration.php::getDefaultConfigArrayComments()

Actions
Copy link
 #1

Updated by Gerrit Code Review about 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50265

Actions
Copy link
 #2

Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50265

Actions
Copy link
 #3

Updated by Gerrit Code Review about 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50265

Actions
Copy link
 #4

Updated by Gerrit Code Review about 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50265

Actions
Copy link
 #5

Updated by Gerrit Code Review about 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50338

Actions
Copy link
 #6

Updated by Stefan Neufeind about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Gerrit Code Review about 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50445

Actions
Copy link
 #8

Updated by Gerrit Code Review about 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50446

Actions
Copy link
 #9

Updated by Markus Klein about 8 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #10

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF