Project

General

Profile

Actions

Bug #78353

closed

PageLayoutView::makeQueryArray (inherited from AbstractDatabaseRecordList) creates invalid SQL

Added by Claus Due about 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2016-10-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Steps to reproduce:

  • Register a content preview hook
  • From within that hook, call `$parentObject->makeQueryArray('tt_content', $ignoredUid, 'AND uid > 0');`
  • Resulting query contains `1=1 AND uid > 0 1=1`

Behavior is different compared to LTS at least and comparing the commit that changed the returned query it also seems clear that the condition would be malformed if returned this way.

Returning an empty string solves the problem and does not break the search feature.

Actions #1

Updated by Gerrit Code Review about 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50284

Actions #2

Updated by Anonymous about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF