Bug #78402
closedScrutinizer issues: ShortcutToolbarItem.php
100%
Description
It seems like $pageRow defined by \TYPO3\CMS\Backend\Utili...9;pages', $pageId) on line 304 can also be of type null; however, TYPO3\CMS\Core\Authentic...n::doesUserHaveAccess() does only seem to accept array, maybe add an additional type check?
It seems like $module defined by \TYPO3\CMS\Core\Utility\...OST on line 644 can also be of type array; however, TYPO3\CMS\Backend\Backen...lbarItem::addShortcut() does only seem to accept string, maybe add an additional type check?
The variable $pageId does not seem to be defined for all execution paths leading up to this point.
The expression $backendUser->isInWebMount($pageId) of type integer|null is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.
Updated by Gerrit Code Review about 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50341
Updated by Gerrit Code Review about 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50341
Updated by Marc Willmann about 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b2bfeb7d737fd137ed658a02b80ba2e40de04a16.