Bug #78718

ViewHelpers do not compile similarly on 7.6 LTS and v8+

Added by Claus Due over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2016-11-16
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Due to differences in signatures of the compile() method on the former and current versions of Fluid, third-party ViewHelpers cannot implement a compile method which works on both versions.

The TYPO3 core should provide a legacy version of the compiling assistant traits on 7.6 and a set of aliases on 8.5+ which can be used in third party ViewHelpers to make them compile on 7.6 and 8.5+ using the same logic.

NB: a proof of concept for such aliases and legacy versions of compiling traits can be found at https://github.com/NamelessCoder/typo3-cms-fluid-gap and has been thoroughly tested to work on both versions. The few hundred lines of code they contain (which are only needed on 7.6; v8 can make do with a simple alias) make it possible for packages like VHS to offer greatly improved performance on both versions. Other extensions such as News and Powermail can adopt the aliases as well without risking incompatibility.

Associated revisions

Revision 99133d7f (diff)
Added by Claus Due over 1 year ago

[TASK] Import forward-compatible Fluid compiling Traits

This change will allow third party ViewHelpers to
adopt the traits and benefit from
the same compiling support in TYPO3 7.6 as on v8.5+.

Change-Id: I6ac8eb59b4fde37a472d2a1e113fb7c0ec4b71a9
Resolves: #78718
Releases: 7.6
Reviewed-on: https://review.typo3.org/50676
Reviewed-by: Helmut Hummel <>
Tested-by: TYPO3com <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Claus Due over 1 year ago

  • Category set to Fluid

#2 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50674

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50676

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50676

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50676

#6 Updated by Anonymous over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF