Bug #78925

PageLayoutController::renderQuickEdit() will throw exception for empty pages

Added by Manuel Selbach almost 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2016-12-08
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If there is an empty page (no content elements on it) the method PageLayoutController::renderQuickEdit() will throw an exception on certain DBMS (depends on it's configuration), as the parameter $this->eRParts1 will hold e.g. /new/1 which will be use in the Query as integer to get a sys_history record. As it is a "new" element there couldn't be a history entry at all, so let's skip that Query if the parameter $this->eRParts1 can not be interpreted as integer.

Associated revisions

Revision eb3b2deb (diff)
Added by Manuel Selbach almost 3 years ago

[BUGFIX] Fix exception in QuickEdit mode for empty pages

If there is no content on a page the parameter $this->eRParts1 will be
set to e.g. /new/1 which is not an integer value and it will throw an
exception here on certain dbms, thus let's check that before as there could
not be a history on a new record and skip the query to prevent the error.

Change-Id: If33c5de067b7685e5723ceb7aa1586640abc99d8
Resolves: #78925
Releases: master, 7.6, 6.2
Reviewed-on: https://review.typo3.org/50910
Tested-by: TYPO3com <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Alexander Stehlik <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>
Reviewed-by: Michael Oehlhof <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision d3cd783c (diff)
Added by Manuel Selbach almost 3 years ago

[BUGFIX] Fix exception in QuickEdit mode for empty pages

If there is no content on a page the parameter $this->eRParts1 will be
set to e.g. /new/1 which is not an integer value and it will throw an
exception here on certain dbms, thus let's check that before as there could
not be a history on a new record and skip the query to prevent the error.

Change-Id: If33c5de067b7685e5723ceb7aa1586640abc99d8
Resolves: #78925
Releases: master, 7.6, 6.2
Reviewed-on: https://review.typo3.org/50910
Reviewed-on: https://review.typo3.org/50945
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 8095288e (diff)
Added by Manuel Selbach almost 3 years ago

[BUGFIX] Fix exception in QuickEdit mode for empty pages

If there is no content on a page the parameter $this->eRParts1 will be
set to e.g. /new/1 which is not an integer value and it will throw an
exception here on certain dbms, thus let's check that before as there could
not be a history on a new record and skip the query to prevent the error.

Change-Id: If33c5de067b7685e5723ceb7aa1586640abc99d8
Resolves: #78925
Releases: master, 7.6, 6.2
Reviewed-on: https://review.typo3.org/50946
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50910

#2 Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50910

#3 Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50945

#4 Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50945

#5 Updated by Manuel Selbach almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50946

#7 Updated by Manuel Selbach almost 3 years ago

  • Status changed from Under Review to Resolved

#8 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF