Project

General

Profile

Actions
Copy link

Bug #79370

closed

PagePositionMap::onClickEvent needs to be more dynamic to act as a proper hook

Added by Alexander Schnitzler almost 8 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2017-01-18
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

if ($TSconfigProp['overrideWithExtension']) {
    if (ExtensionManagementUtility::isLoaded($TSconfigProp['overrideWithExtension'])) {
        $onclick = 'window.location.href=' . GeneralUtility::quoteJSvalue(ExtensionManagementUtility::extRelPath($TSconfigProp['overrideWithExtension']) . 'mod1/index.php?cmd=crPage&positionPid=' . $pid) . ';';
        return $onclick;
    }
}

I am not sure but I think this "hook" has been put there for templavoila in the first place. Back then, it was quite normal to put modules in folders like mod1, but these days, as we have getModuleUrl, this hook is outdated and very likely to be non-working with modern extensions.
Therefore I'd either remove that hook or refactor it, so it resolves the path to the module dynamically.

Actions
Copy link

Also available in: Atom PDF