Project

General

Profile

Actions
Copy link

Bug #80844

closed

Registering an Extbase BE module with an iconIdentifier falsely falls back to the default icon if the icon is not explicitly unset

Added by Simon Schaufelberger about 7 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Extbase
Target version:
-
Start date:
2017-04-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

This code snippet worked in TYPO3 7 while in TYPO3 8 the extbase icon is shown:

using: iconIdentifier

$iconRegistry = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(
    \TYPO3\CMS\Core\Imaging\IconRegistry::class
);
$iconRegistry->registerIcon(
    'module-seo',
    \TYPO3\CMS\Core\Imaging\IconProvider\FontawesomeIconProvider::class,
    ['name' => 'bullseye']
);

\TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule(
    $_EXTKEY,
    'metaseo',
    '',
    '',
    [],
    [
        'access' => 'user,group',
        'iconIdentifier' => 'module-seo',
        'labels' => 'LLL:EXT:' . $_EXTKEY . '/Resources/Private/Language/ModuleMain/locallang.xlf',
    ]
);

in TYPO3 8 i need to "unset" the extbase icon which gets merged into the options array:

'icon' => '',
'iconIdentifier' => 'module-seo',

related commits:
https://github.com/TYPO3/TYPO3.CMS/commit/241497a2ab5e34501ead41106e021de0145b8332
https://github.com/TYPO3/TYPO3.CMS/commit/562b7c1d19d29579f86082596c6493207b2d4da8

I'm quite sure this piece of code is responsible for it:

https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php#L942-L953

See also: https://github.com/mblaschke/TYPO3-metaseo/pull/417

Actions
Copy link

Also available in: Atom PDF