http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692017-10-23T14:57:39ZTYPO3 ForgeTYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3466892017-10-23T14:57:39ZFrancois Suterfrancois@typo3.org
<ul></ul><p>As amazing at is may sound, I confirm that it is so. I was facing a blank page in a workspace preview and started looking for related bugs. Disabling my page made the content appear...</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3499842017-10-31T15:33:52ZR3 H6r3h6@outlook.com
<ul></ul><p>Can confirm this problem and behavior.</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3507042017-11-13T14:23:45ZFlorian Rivalflorian.typo3@oktopuce.fr
<ul><li><strong>File</strong> <a href="/attachments/32888">bug_82462.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/32888/bug_82462.diff">bug_82462.diff</a> added</li></ul><p>When working with workspaces, two pages are created with ID : X and X+1 but when the workspace page is updated (id x+1), the column hidden of the reference page (id x) is not updated. When we want to view this page, the process is looking for page content with page flag "hidden=0" but this page still has hidden flag set to 1 because it wasn't updated.<br />Here is a patch to update the hidden flag for reference page when workspace page is updated.</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3508582017-11-14T22:52:42ZGabe Blairgabe@castironcoding.com
<ul></ul><p>I can confirm this behavior in TYPO3 8.7.8. I tried Florian's patch, and it does appear to fix the issue (after starting over with the content edits). Should this be considered a regression?</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3595192018-03-01T15:42:25ZPatrick Gaumondgaumondpatrick@gmail.com
<ul></ul><p>Just tried the patch and it worked for us. TYPO3 8.7.10.</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3595252018-03-01T16:23:17ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/55967">https://review.typo3.org/55967</a></p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3652102018-05-12T16:11:00ZRiccardo De Contardierredeco@gmail.com
<ul></ul><p>Sorry wrong patch target commit. My apologies</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3654452018-05-15T12:00:38ZOliver Haderoliver.hader@typo3.org
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/85003">Bug #85003</a>: Workspace : no content show in preview frontend, if live page is hidden</i> added</li></ul> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3897522018-10-29T11:58:22ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/55967">https://review.typo3.org/55967</a></p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3908822018-11-16T14:27:13ZGianluca Strafella
<ul></ul><p>The patch doesn't work for us. We've tried on TYPO3 8.7.20 (cleaned).</p>
<p>These the start conditions:<br />- In LIVE, page already published, but not visible (hidden=1)<br />- In WORKSPACE, the same page was modified adding a new content element</p>
<p>If the page in workspace is hidden as in LIVE, the new content is visible via preview and preview link.<br />If the page in workspace is visible (hidden=0), all contents in the page aren't visible.</p>
<p>We have found a possible problem in the TYPO3 core:</p>
<p>class: TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController<br />method: determineIdIsHiddenPage</p>
<pre>
protected function determineIdIsHiddenPage()
{
//...
if ($workspace !== 0 && $workspace !== false) {
// Fetch overlay of page if in workspace and check if it is hidden
$pageSelectObject = GeneralUtility::makeInstance(PageRepository::class);
$pageSelectObject->versioningPreview = true;
$pageSelectObject->init(false);
$targetPage = $pageSelectObject->getWorkspaceVersionOfRecord($this->whichWorkspace(), 'pages',
$page['uid']);
//>>>>>>> here a problem: in this case getWorkspaceVersionOfRecord return an array with ws page
$result = $targetPage === -1 || $targetPage === -2 || (is_array($targetPage) && $targetPage['hidden'] == 0 && $page['hidden'] == 1);
//<<<<<<
} else {
$result = is_array($page) && ($page['hidden'] || $page['starttime'] > $GLOBALS['SIM_EXEC_TIME'] || $page['endtime'] != 0 && $page['endtime'] <= $GLOBALS['SIM_EXEC_TIME']);
}
}
</pre>
<p>As a work around, we fixed with this row:<br /><pre>
$result = $targetPage === -1 || $targetPage === -2 || (is_array($targetPage) && $targetPage['hidden'] == 0 && $page['hidden'] == 1);
</pre></p>
<p>Gianluca</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3922422018-12-14T11:10:01ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/55967">https://review.typo3.org/55967</a></p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3942072019-01-30T17:07:44ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/55967">https://review.typo3.org/55967</a></p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3946442019-02-06T14:49:32ZPhilip Burggraf
<ul></ul><p>The issue still exists in v9.5.4 and is reproducible with the exact same steps as in the initial bug report.<br />However, we've also encountered this issue when creating a new page in the workspace.</p>
<p>Steps to reproduce:<br />1. Create a workspace and use it<br />2. Create a new page<br />3. Add some content elements to the page<br />4. Enable the newly created page (Right click in the page tree on the page -> "Enable")<br />5. Preview the page (Right click in the page tree on the page -> "Show")</p>
<p>Result: The created content elements are not visible.</p>
<p>To get the expected result (be able to view the content elements) you must disable the page.<br />1. Disable the created page again (Right click in the page tree on the page -> "disable")<br />2. Reload the preview page</p>
<p>Result: The content elements are visible.</p>
<p>You'll be able to view the content elements, regardless if the page is enabled or not, if you apply the workaround from Gianluca Strafella.<br />Note: You must flush all caches after editing the TypoScriptFrontendController.</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3974622019-03-31T17:05:27ZRiccardo De Contardierredeco@gmail.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-3 priority-lowest closed" href="/issues/83065">Bug #83065</a>: Content is disappearing in Page module in workspaces</i> added</li></ul> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3974642019-03-31T17:05:44ZRiccardo De Contardierredeco@gmail.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/85742">Bug #85742</a>: New page in workspace doesn't load content elements in preview</i> added</li></ul> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3974752019-04-01T09:40:18ZRiccardo De Contardierredeco@gmail.com
<ul></ul><p>I report here my comment 6 on <a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: Content is disappearing in Page module in workspaces (Closed)" href="http://forge.typo3.org/issues/83065">#83065</a> as a quick way to reproduce the issue on the latest master:</p>
<p>The issue is still present on 10.0.0-dev (latest master); it is easy to reproduce:</p>
<p>1) Have a plain TYPO3 installation <br />2) Create a draft Workspace<br />3) Create a page in the Workspace<br />4) Add a content element to the page<br />5) Save and preview the page</p>
<a name="Expected-result"></a>
<h3 >Expected result:<a href="#Expected-result" class="wiki-anchor">¶</a></h3>
<p>the content element should be visible in the preview</p>
<a name="Current-result"></a>
<h3 >Current result<a href="#Current-result" class="wiki-anchor">¶</a></h3>
<p>the content element is not visible.</p>
<p>if the page created in workspace is marked as hidden (disabled), then the content element becomes visible (tested with 10.0.0-dev).</p>
<p>Please note that <a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: Content is disappearing in Page module in workspaces (Closed)" href="http://forge.typo3.org/issues/83065">#83065</a> had this review attached <a class="external" href="https://review.typo3.org/54724">https://review.typo3.org/54724</a> that was abandoned.</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=3974762019-04-01T09:40:35ZRiccardo De Contardierredeco@gmail.com
<ul></ul><p>Please note that <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: New page in workspace doesn't load content elements in preview (Closed)" href="http://forge.typo3.org/issues/85742">#85742</a> had this review attached <a class="external" href="https://review.typo3.org/57822">https://review.typo3.org/57822</a> that was reverted with <a class="external" href="https://review.typo3.org/58838">https://review.typo3.org/58838</a></p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4021642019-06-19T13:49:21ZAnatoli Zich
<ul></ul><p>Im not sure if i should open up a new bug but i think this is related:<br />This also applies to live pages with unmet start and expiration date conditions.</p>
<p>Steps to reproduce (TYPO3 8-10):<br />1) Have a plain TYPO3 installation<br />2) Create a draft Workspace<br />3) Create a page in live mode<br />4) Add a content element to that page<br />5) Set the expiration date of the page to something in the past and save<br />6) Switch to draft Workspace<br />7) Remove the expiration date from the page<br />8) Save and preview the page</p>
<p>Expected result:<br />You should be able to see page and its content elements.</p>
<p>Current result:<br />You'll be able to view the page but no content elements appear.</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4033902019-07-18T14:32:46ZHannes Bochmann
<ul></ul><p>The patch in this issue fixes the problem for this issue but not for the related <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Workspace : no content show in preview frontend, if live page is hidden (Closed)" href="http://forge.typo3.org/issues/85003">#85003</a>. The proposed patch of Gianluca fixes both issues. But as I stated in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Workspace : no content show in preview frontend, if live page is hidden (Closed)" href="http://forge.typo3.org/issues/85003">#85003</a> it seems to me that none of the patches tackle the right spot.</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4092732019-11-09T10:14:10ZBenni Mackbenni@typo3.org
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/89455">Bug #89455</a>: Translations/Localized records are not visible in Workspace Preview</i> added</li></ul> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4097552019-11-18T13:11:37ZOliver Haderoliver.hader@typo3.org
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>On Hold</i></li></ul><p>Handled in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Translations/Localized records are not visible in Workspace Preview (Closed)" href="http://forge.typo3.org/issues/89455">#89455</a> - once done, related issues should be re-evaluated again (then either to be closed or adjusted)</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4097562019-11-18T13:12:08ZOliver Haderoliver.hader@typo3.org
<ul><li><strong>Assignee</strong> set to <i>Oliver Hader</i></li></ul> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4229352020-04-17T16:42:12ZRiccardo De Contardierredeco@gmail.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/80995">Bug #80995</a>: Content of hidden page not shown in workspace preview</i> added</li></ul> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4229412020-04-17T17:02:22ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>On Hold</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/64215">https://review.typo3.org/c/Packages/TYPO3.CMS/+/64215</a></p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4229432020-04-17T17:03:06ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/64215">https://review.typo3.org/c/Packages/TYPO3.CMS/+/64215</a></p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4229472020-04-17T17:22:12ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/64215">https://review.typo3.org/c/Packages/TYPO3.CMS/+/64215</a></p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4229492020-04-17T17:32:43ZRiccardo De Contardierredeco@gmail.com
<ul></ul><p>If I repeat my test on comment 16, it looks like the issue is already resolved even without the patch (tested on latest master) ; am I wrong?</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4230752020-04-19T08:07:09ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/64215">https://review.typo3.org/c/Packages/TYPO3.CMS/+/64215</a></p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4230842020-04-19T10:35:38ZRiccardo De Contardierredeco@gmail.com
<ul></ul><p>Test on comment 18 still happens on latest master</p> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4282302020-07-30T13:07:23ZChristian Kuhnlolli@schwarzbu.ch
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-1 priority-4 priority-default" href="/issues/91899">Bug #91899</a>: Workspace: No content elements in preview if live page has endtime in the past</i> added</li></ul> TYPO3 Core - Bug #82462: Workspace : no content show in preview, for a new page create in workspace, if this page is enablehttp://forge.typo3.org/issues/82462?journal_id=4282312020-07-30T13:11:28ZChristian Kuhnlolli@schwarzbu.ch
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Closed</i></li></ul><p>I confirm the initial issue has been solved.</p>
<p>The case from comment #18 is slightly different, though.<br />To keep the 'workspace preview' issues straight, I created issue <a class="issue tracker-1 status-1 priority-4 priority-default" title="Bug: Workspace: No content elements in preview if live page has endtime in the past (New)" href="http://forge.typo3.org/issues/91899">#91899</a> for case "if live page has stop time in the past, workspace page shows no content elements in preview".</p>
<p>Closing this issue.</p>