Bug #82732

Context menu is not completely visible when foldertree of filelist has a scrollbar

Added by Wittkiel Gruppe 13 days ago. Updated 10 days ago.

Status:
Resolved
Priority:
Must have
Assignee:
-
Category:
Backend JavaScript
Target version:
-
Start date:
2017-10-11
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you rightclick on a folder at the bottom of the filelist-foldertree the context menu is opening but is not completely visible.

The error seems to be here sysext/backend/Resources/Public/JavaScript/ContextMenu.js:

var dimsWindow = {
    width: $(document).width() - 20, // saving margin for scrollbars
    height: $(document).height()
};

I think in "dimsWindow" should be the values of $(window) instead of $(document), because if there is a scrollbar, the context menu is always shown at the bottom.

http://api.jquery.com/height/

// Returns height of browser viewport
$( window ).height();

// Returns height of HTML document
$( document ).height();

TYPO3: 8.7.7
Browser: Firefox 56
OS: Windows 8.1

bug-context-menu-positioning.png View (142 KB) Wittkiel Gruppe, 2017-10-11 11:52

bug-context-menu-positioning-console.png View (18 KB) Wittkiel Gruppe, 2017-10-11 11:54

Associated revisions

Revision d0556bc1 (diff)
Added by Gianluigi Martino 10 days ago

[BUGFIX] Context menu is not completely visible in filelist with scrollbar

If the foldertree in filelist is to long, the rightclick context menu on
the bottom of the window is not completly visible. With this patch the
position of the menu is calculated based on the windows width and height
and so completly visible.

Resolves: #82732
Releases: master, 8.7
Change-Id: Ied9204371491059efda61143e9ca9c2f3c8a9b9d
Reviewed-on: https://review.typo3.org/54390
Tested-by: TYPO3com <>
Reviewed-by: Wittkiel Gruppe <>
Tested-by: Wittkiel Gruppe <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

Revision 4d048f81 (diff)
Added by Gianluigi Martino 10 days ago

[BUGFIX] Context menu is not completely visible in filelist with scrollbar

If the foldertree in filelist is to long, the rightclick context menu on
the bottom of the window is not completly visible. With this patch the
position of the menu is calculated based on the windows width and height
and so completly visible.

Resolves: #82732
Releases: master, 8.7
Change-Id: Ied9204371491059efda61143e9ca9c2f3c8a9b9d
Reviewed-on: https://review.typo3.org/54392
Tested-by: TYPO3com <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

History

#1 Updated by Gerrit Code Review 11 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54390

#2 Updated by Gerrit Code Review 10 days ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54392

#3 Updated by Gianluigi Martino 10 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF