Bug #83021

EXT:form override settings

Added by Maik Hagenbruch over 1 year ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2017-11-17
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Szenario:
- Create form in backend
- improve settings in yaml config file
- include form on page in backend and use the option "Override finisher settings"

For example, i set the subject for MailToAdmin in my yaml file but need other email-addresses on each system.
Now i get an error on sending this mail, because i did not set the subject in override settings.

I think there should be a test for this. If i set an override so take this value, but if not, so take this value from yaml config.

Associated revisions

Revision c955b4dc (diff)
Added by Daniel Lorenz over 1 year ago

[BUGFIX] Require mail subject in finisher overrides

Resolves: #83021
Releases: master, 8.7
Change-Id: Ic88731ce7f2b698d39aca6944cf0257a8a758420
Reviewed-on: https://review.typo3.org/54943
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>
Tested-by: TYPO3com <>
Reviewed-by: Bjoern Jacob <>
Tested-by: Bjoern Jacob <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

Revision 42fd7196 (diff)
Added by Daniel Lorenz over 1 year ago

[BUGFIX] Require mail subject in finisher overrides

Resolves: #83021
Releases: master, 8.7
Change-Id: Ic88731ce7f2b698d39aca6944cf0257a8a758420
Reviewed-on: https://review.typo3.org/54951
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

History

#1 Updated by Ralf Zimmermann over 1 year ago

  • Assignee deleted (Bjoern Jacob)

There is only a missing "eval: 'required'" within the FormEngineSetup.yaml for the subject property.
We do not need any further tests here.
I will push a patchset asap.

#2 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54943

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54943

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54951

#5 Updated by Daniel Lorenz over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF