Bug #83299

Do not register tree component before it's fully initialized

Added by Tymoteusz Motylewski about 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Pagetree
Target version:
-
Start date:
2017-12-12
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Registration of the navigation component inside pagetreeElement.js needs to be moved inside done callback of the ajax action (after tree.initialize is called).

This will prevent issues like:

SyntaxError: Unexpected token < in JSON at position 0
    at JSON.parse (<anonymous>)
    at Object.<anonymous>

thrown e.g. when undeleting a page from recycler.

Associated revisions

Revision a9326c52 (diff)
Added by Tymoteusz Motylewski about 2 years ago

[BUGFIX] Register page tree navigation component after it is initialized

Now Viewport.NavigationContainer.setComponentInstance(tree);
is called after the tree is initialized.
A check to prevent multiple initialization calls is added.

Also position of the title edit imput is corrected
in case where there are multiple mount points.

Releases: master
Resolves: #83299
Change-Id: I5b9cc14b362ab20ecb7631babe3f3f83eb8bfb48
Reviewed-on: https://review.typo3.org/55043
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>
Reviewed-by: Frans Saris <>
Reviewed-by: Wouter Wolters <>
Tested-by: Frans Saris <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

History

#1 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55043

#2 Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55043

#3 Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55043

#4 Updated by Gerrit Code Review about 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55043

#5 Updated by Gerrit Code Review about 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55043

#6 Updated by Tymoteusz Motylewski about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF