Bug #83747

"Select & upload files" does not work for FAL in flexform

Added by Armin Vieweg 10 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2018-02-01
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

When using a FAL/inline configuration inside of flexform, the "Select & upload files" button has no functionality.

Also the console throws errors:

Uncaught Error: Syntax error, unrecognized expression: #data-1-tt_content-NEW5a72d63c613d4814805180-pi_flexform---data---sheet$1tabGeneral---lDEF---settings$1test---vDEF

It seems, that the $1 are the problem, which just occure in 8.7.
In 7.6 those values are splitted by dots. e.g. "sheet.tabGeneral"


I guess this change broke it:

File: typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php

Before:

data-dropzone-target="#' . htmlspecialchars($this->inlineStackProcessor->getCurrentStructureDomObjectIdPrefix($this->data['inlineFirstPid'])) . '"

After:

data-dropzone-target="#' . htmlspecialchars(StringUtility::escapeCssSelector($currentStructureDomObjectIdPrefix)) . '"


2018-02-01_0935.png View (8.04 KB) Armin Vieweg, 2018-02-01 09:35


Related issues

Related to TYPO3 Core - Bug #81812: Drag and drop file upload is not working in DCE file upload fields (ie. fields using flexforms) Closed 2017-07-06

Associated revisions

Revision 13260552 (diff)
Added by Armin Vieweg 10 months ago

[BUGFIX] Fix "Select & upload files" button for FAL in flexform

Fix regular expression in escapeCssSelector method, to convert
e.g. "." to "\.".

Resolves: #83747
Branches: master, 8.7
Change-Id: I0fe19fb3590e28cafce6e2fd0cbf9a63f4375954
Reviewed-on: https://review.typo3.org/55516
Reviewed-by: Armin Vieweg <>
Tested-by: Armin Vieweg <>
Tested-by: TYPO3com <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 2b686bbb (diff)
Added by Armin Vieweg 10 months ago

[BUGFIX] Fix "Select & upload files" button for FAL in flexform

Fix regular expression in escapeCssSelector method, to convert
e.g. "." to "\.".

Resolves: #83747
Branches: master, 8.7
Change-Id: I0fe19fb3590e28cafce6e2fd0cbf9a63f4375954
Reviewed-on: https://review.typo3.org/55520
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Georg Ringer 10 months ago

  • Is Regression set to Yes

#2 Updated by Georg Ringer 10 months ago

  • Related to Bug #81812: Drag and drop file upload is not working in DCE file upload fields (ie. fields using flexforms) added

#3 Updated by Georg Ringer 10 months ago

#81812 is the issue of the change

#4 Updated by Armin Vieweg 10 months ago

Yeah thanks. So dots should not escape. Do you provide a patch? I would simply remove the escapeCssSelector call here.

#5 Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55516

#6 Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55516

#7 Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55516

#8 Updated by Gerrit Code Review 10 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55516

#9 Updated by Gerrit Code Review 10 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55516

#10 Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55520

#11 Updated by Armin Vieweg 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF