Project

General

Profile

Actions

Bug #83747

closed

"Select & upload files" does not work for FAL in flexform

Added by Armin Vieweg about 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2018-02-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

When using a FAL/inline configuration inside of flexform, the "Select & upload files" button has no functionality.

Also the console throws errors:

Uncaught Error: Syntax error, unrecognized expression: #data-1-tt_content-NEW5a72d63c613d4814805180-pi_flexform---data---sheet$1tabGeneral---lDEF---settings$1test---vDEF

It seems, that the $1 are the problem, which just occure in 8.7.
In 7.6 those values are splitted by dots. e.g. "sheet.tabGeneral"


I guess this change broke it:

File: typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php

Before:

data-dropzone-target="#' . htmlspecialchars($this->inlineStackProcessor->getCurrentStructureDomObjectIdPrefix($this->data['inlineFirstPid'])) . '"

After:

data-dropzone-target="#' . htmlspecialchars(StringUtility::escapeCssSelector($currentStructureDomObjectIdPrefix)) . '"



Files

2018-02-01_0935.png (8.04 KB) 2018-02-01_0935.png Armin Vieweg, 2018-02-01 09:35

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #81812: Drag and drop file upload is not working in DCE file upload fields (ie. fields using flexforms)ClosedMarkus Klein2017-07-06

Actions
Actions #1

Updated by Georg Ringer about 6 years ago

  • Is Regression set to Yes
Actions #2

Updated by Georg Ringer about 6 years ago

  • Related to Bug #81812: Drag and drop file upload is not working in DCE file upload fields (ie. fields using flexforms) added
Actions #3

Updated by Georg Ringer about 6 years ago

#81812 is the issue of the change

Actions #4

Updated by Armin Vieweg about 6 years ago

Yeah thanks. So dots should not escape. Do you provide a patch? I would simply remove the escapeCssSelector call here.

Actions #5

Updated by Gerrit Code Review about 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55516

Actions #6

Updated by Gerrit Code Review about 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55516

Actions #7

Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55516

Actions #8

Updated by Gerrit Code Review about 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55516

Actions #9

Updated by Gerrit Code Review about 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55516

Actions #10

Updated by Gerrit Code Review about 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55520

Actions #11

Updated by Armin Vieweg about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #12

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF