Project

General

Profile

Actions

Bug #84742

closed

TCA migration labels are wrong

Added by Johannes Schlier over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-04-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

When I run the TCA migration there are several issues with the labels that come up:

Reference to "wizard_element_browser" 
was migrated from"tt_content['columns']['somecolumn']['config']['wizards']['link']['module']['name'] === 'wizard_element_browser'"to new "wizard_link",
"tt_content['columns']['somecolumn']['config']['wizards']['link']['module']['name'] = 'wizard_link' " 

Here, it's just spaces missing before and after the old name of the setting.
The 'foreign_record_defaults' property from TCA pages['types']['20']['columnOverrides']['somecolumn']['config']['anothercolumn']
and has been migrated to pages['types']['20']['columnOverrides']['somecolumn']['config']['overrideChildTca']['columns']['anothercolumn']['config']['default']

Here, the sentence itself is not a valid sentence. My guess is that the "and" should not be there, which would make the sentence correct.
More importantly though, the setting that has been changed is referenced to as "columnOverrides", which does not exist. It should read "column s Overrides".
This can lead to breaking changes that someone makes when simply following the instructions.

Looking over the code in TcaMigrations.php, these are just a few of the issues that are in there.
Even when it's 'just' the administrator of the web site that sees these messages, they should still be grammatically correct sentences, should correctly separate words with spaces and most importantly should contain no misinformation.

Actions #1

Updated by Johannes Schlier over 6 years ago

  • Subject changed from TCA Migration Labels are wrong to TCA migration labels are wrong
Actions #2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56678

Actions #3

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56682

Actions #4

Updated by Georg Ringer over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF