Bug #84791

EXT:backend: missing file existence check for backend logo

Added by Lidia Demin about 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2018-04-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Problem:
If the file given in backendLogo field of EXT:backend is invalid, an exception is thrown:

#1476107295: PHP Warning: getimagesize(/.../typo3conf/ext/bvm_sitepackage/Resources/Public/image/backend-logo.png): failed to open stream: No such file or directory in /.../vendor/typo3/cms/typo3/sysext/core/Classes/Type/File/ImageInfo.php line 58 (More information)

TYPO3\CMS\Core\Error\Exception thrown in file
/.../vendor/typo3/cms/typo3/sysext/core/Classes/Error/ErrorHandler.php in line 107.

The backend is not accessible any more.

Cause:
Such a check is missing in TYPO3\CMS\Backend\Controller::renderTopbar() [L: 405] although it's described in the comment:

 // if no custom logo was set or the path is invalid, use the original one
if (empty($logoPath)) {

This results in the invalid file path being called instead of using the default file.


Files

ext-backend-logo-field.png (13.9 KB) ext-backend-logo-field.png Lidia Demin, 2018-04-19 10:28
#1

Updated by Dan Untenzu about 3 years ago

The backend is not accessible any more.

Problem is, that this value is set in EXT:backend via extension manager and then stored as serialized array in LocalConfiguration.php. If we set a wrong value, the backend is not useable anymore and there is no way to fix this then removing the configuration for EXT:backend in LocalConfiguration.php by hand.

#2

Updated by Lidia Demin about 3 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
#3

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF