http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692018-04-27T10:09:32ZTYPO3 ForgeTYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3645422018-04-27T10:09:32ZDavid Gurkdgbox+typo3forge@pm.me
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/26753">Bug #26753</a>: Picture in backend list module will be displayed after change element type from picture to text</i> added</li></ul> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3645532018-04-27T11:07:33ZJörg Vellettijvelletti@allplan.com
<ul></ul><p>I can confirm that behavior</p>
<p>- still works in 8.7.13 when the column is NOT in a palette<br />- does not work is inside of a palette</p>
<p>the only solution to expand the $visibleColumns with all included columns from used palettes in that type</p>
<p>means after 1456: <br />$visibleColumns = $GLOBALS['TCA'][$table]['types'][$type]['showitem'];</p>
<p>replace all --palette-- configs with content of that palette ..</p>
<p>addig this 3 lines (maybe not the perfect code):</p>
<pre><code class="php syntaxhl" data-language="php"> <span class="k">foreach</span> <span class="p">(</span> <span class="nv">$GLOBALS</span><span class="p">[</span><span class="s1">'TCA'</span><span class="p">][</span><span class="nv">$table</span><span class="p">][</span><span class="s1">'palettes'</span><span class="p">]</span> <span class="k">as</span> <span class="nv">$key</span> <span class="o">=></span> <span class="nv">$palette</span> <span class="p">)</span> <span class="p">{</span>
<span class="nv">$visibleColumns</span> <span class="o">=</span> <span class="nb">str_replace</span><span class="p">(</span> <span class="nv">$key</span> <span class="p">,</span> <span class="nv">$palette</span><span class="p">[</span><span class="s1">'showitem'</span><span class="p">]</span> <span class="p">,</span> <span class="nv">$visibleColumns</span> <span class="p">)</span> <span class="p">;</span>
<span class="p">}</span>
</code></pre>
<p>solved it</p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3645602018-04-27T11:52:06ZDavid Gurkdgbox+typo3forge@pm.me
<ul></ul><p>Jörg Velletti wrote:</p>
<blockquote>
<p>addig this 3 lines (maybe not the perfect code):</p>
<p>solved it</p>
</blockquote>
<p>Nice! Would you mind to create a patch? Maybe we can get more feedback in the review phase.</p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3645662018-04-27T15:28:53ZDavid Gurkdgbox+typo3forge@pm.me
<ul></ul><p>My suggested solution would slightly different:<br /><pre><code class="php syntaxhl" data-language="php"><span class="c1">// Flatten palettes into types showitem</span>
<span class="nv">$visibleColumns</span> <span class="o">=</span> <span class="nv">$GLOBALS</span><span class="p">[</span><span class="s1">'TCA'</span><span class="p">][</span><span class="nv">$table</span><span class="p">][</span><span class="s1">'types'</span><span class="p">][</span><span class="nv">$type</span><span class="p">][</span><span class="s1">'showitem'</span><span class="p">];</span>
<span class="k">foreach</span> <span class="p">(</span><span class="nv">$GLOBALS</span><span class="p">[</span><span class="s1">'TCA'</span><span class="p">][</span><span class="nv">$table</span><span class="p">][</span><span class="s1">'palettes'</span><span class="p">]</span> <span class="k">as</span> <span class="nv">$key</span> <span class="o">=></span> <span class="nv">$palette</span><span class="p">)</span> <span class="p">{</span>
<span class="nv">$paletteColumns</span> <span class="o">=</span> <span class="nb">rtrim</span><span class="p">(</span><span class="nv">$palette</span><span class="p">[</span><span class="s1">'showitem'</span><span class="p">],</span> <span class="s1">','</span><span class="p">);</span>
<span class="nv">$visibleColumns</span> <span class="o">=</span> <span class="nb">preg_replace</span><span class="p">(</span>
<span class="s1">'/--palette--;[^;]*;('</span> <span class="mf">.</span> <span class="nv">$key</span> <span class="mf">.</span> <span class="s1">')/'</span><span class="p">,</span>
<span class="nv">$paletteColumns</span><span class="p">,</span>
<span class="nv">$visibleColumns</span>
<span class="p">);</span>
<span class="p">}</span>
<span class="k">if</span> <span class="p">(</span><span class="nv">$this</span><span class="o">-></span><span class="n">thumbs</span> <span class="o">&&</span>
<span class="nb">trim</span><span class="p">(</span><span class="nv">$row</span><span class="p">[</span><span class="nv">$thumbsCol</span><span class="p">])</span> <span class="o">&&</span>
<span class="nb">preg_match</span><span class="p">(</span><span class="s1">'/(^|(.*(;|,)?))'</span> <span class="mf">.</span> <span class="nv">$thumbsCol</span> <span class="mf">.</span> <span class="s1">'(((;|,).*)|$)/'</span><span class="p">,</span> <span class="nv">$visibleColumns</span><span class="p">)</span> <span class="o">===</span> <span class="mi">1</span>
<span class="p">)</span> <span class="p">{</span>
<span class="c1">// [...]</span>
<span class="p">}</span>
<span class="c1">// [...]</span>
</code></pre></p>
<p>Here the RegEx test with showitem from tt_content textmedia:<br /><a class="external" href="https://regex101.com/r/5uIBXb/1/">https://regex101.com/r/5uIBXb/1/</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3645692018-04-27T16:39:15ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3645702018-04-27T17:03:55ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3646592018-05-02T09:17:18ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3651392018-05-11T17:27:02ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3651402018-05-11T17:29:31ZGerrit Code Review
<ul></ul><p>Patch set 5 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3652062018-05-12T15:53:39ZGerrit Code Review
<ul></ul><p>Patch set 6 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3652072018-05-12T15:55:01ZGerrit Code Review
<ul></ul><p>Patch set 7 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3652492018-05-12T20:55:45ZGerrit Code Review
<ul></ul><p>Patch set 8 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3652502018-05-12T20:57:29ZGerrit Code Review
<ul></ul><p>Patch set 9 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3652512018-05-12T21:00:21ZDavid Gurkdgbox+typo3forge@pm.me
<ul></ul><p>Updated regular expression:<br /><a class="external" href="https://regex101.com/r/5uIBXb/5/">https://regex101.com/r/5uIBXb/5/</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3652602018-05-12T23:00:14ZGerrit Code Review
<ul></ul><p>Patch set 10 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3652612018-05-12T23:01:19ZGerrit Code Review
<ul></ul><p>Patch set 11 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3658952018-05-23T14:31:10ZGerrit Code Review
<ul></ul><p>Patch set 12 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3658972018-05-23T14:44:55ZGerrit Code Review
<ul></ul><p>Patch set 13 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3658982018-05-23T14:48:13ZGerrit Code Review
<ul></ul><p>Patch set 14 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3685122018-07-07T17:55:41ZGerrit Code Review
<ul></ul><p>Patch set 15 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3689292018-07-16T09:57:59ZGerrit Code Review
<ul></ul><p>Patch set 16 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3690842018-07-19T11:15:57ZGerrit Code Review
<ul></ul><p>Patch set 17 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3691232018-07-19T17:01:18ZGerrit Code Review
<ul></ul><p>Patch set 18 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/56821">https://review.typo3.org/56821</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3697352018-07-31T14:30:05ZDavid Gurkdgbox+typo3forge@pm.me
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[BUGFIX] Show thumbnail in list module for columns in palettes By replacing the palettes in show..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/ba07dd2a6609332c37e1cc8ef51fdffba837d838">ba07dd2a6609332c37e1cc8ef51fdffba837d838</a>.</p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3697362018-07-31T14:41:15ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>TYPO3_8-7</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/57744">https://review.typo3.org/57744</a></p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3698272018-08-01T22:30:04ZDavid Gurkdgbox+typo3forge@pm.me
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="[BUGFIX] Show thumbnail in list module for columns in palettes By replacing the palettes in show..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/7b54811b18e5e7940762221ed818ae0f0f33cb88">7b54811b18e5e7940762221ed818ae0f0f33cb88</a>.</p> TYPO3 Core - Bug #84885: Images in backend list module aren't shown, if they in a palette http://forge.typo3.org/issues/84885?journal_id=3765212018-10-02T10:47:50ZBenni Mackbenni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>