Project

General

Profile

Actions
Copy link

Task #85362

closed

Reduce amount of Logic in render methods of Vimeo- and YouTubeRenderer

Added by Daniel Goerz over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Could have
Assignee:
Daniel Goerz
Category:
-
Target version:
-
Start date:
2018-06-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
easy
Sprint Focus:

Description

Currently the only public method in the Renderer Classes for YouTube and Vimeo Videos are stacked with logic, making it nnecessaryly difficult to build upon those classes (e.g. register a custom Renderer that should handle YouTube videos. You basically have to copy the whole logic over to your custom renderer in order to produce slightly different markup.

The render methods should be short and simple.

Actions
Copy link
 #1

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57341

Actions
Copy link
 #2

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57341

Actions
Copy link
 #3

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57341

Actions
Copy link
 #4

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57341

Actions
Copy link
 #5

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57341

Actions
Copy link
 #6

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57341

Actions
Copy link
 #7

Updated by Gerrit Code Review over 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57341

Actions
Copy link
 #8

Updated by Gerrit Code Review over 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57341

Actions
Copy link
 #9

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57415

Actions
Copy link
 #10

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57415

Actions
Copy link
 #11

Updated by Daniel Goerz over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #12

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57415

Actions
Copy link
 #13

Updated by Daniel Goerz over 6 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #14

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF